Skip to content

Remove unnecessary fields from EncodeMTG class#250

Merged
dsarmany merged 1 commit intodevelopfrom
fix/python-api-desync
Mar 18, 2026
Merged

Remove unnecessary fields from EncodeMTG class#250
dsarmany merged 1 commit intodevelopfrom
fix/python-api-desync

Conversation

@HCookie
Copy link
Member

@HCookie HCookie commented Mar 18, 2026

Description

Removed geo_from_atlas and cached fields from EncodeMTG class.

Closes #249

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-250

@HCookie HCookie requested a review from tweska March 18, 2026 11:46
@HCookie HCookie self-assigned this Mar 18, 2026
@HCookie HCookie added the bug Something isn't working label Mar 18, 2026
@HCookie HCookie requested a review from dsarmany March 18, 2026 11:48
Copy link
Member

@tweska tweska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should also be removed from this line in a test:

(EncodeMTG, "encode-mtg2", {"geo-from-atlas": True, "cached": True}),

And the cached option still exists, it just doesn't have an effect anymore. But we are planning on reintroducing the functionality again soon.

Co-authored-by: Harrison Cook <Harrison.cook@ecmwf.int>
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.35%. Comparing base (81e662a) to head (b7bc29b).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #250   +/-   ##
========================================
  Coverage    56.35%   56.35%           
========================================
  Files          321      321           
  Lines        21141    21141           
  Branches      1679     1679           
========================================
  Hits         11915    11915           
  Misses        9226     9226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dsarmany dsarmany force-pushed the fix/python-api-desync branch from c0dab41 to b7bc29b Compare March 18, 2026 12:33
@dsarmany dsarmany merged commit b7bc29b into develop Mar 18, 2026
151 checks passed
@dsarmany dsarmany deleted the fix/python-api-desync branch March 18, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python API Desync

4 participants