Remove unnecessary fields from EncodeMTG class#250
Merged
Conversation
tweska
requested changes
Mar 18, 2026
Member
tweska
left a comment
There was a problem hiding this comment.
I think it should also be removed from this line in a test:
And the cached option still exists, it just doesn't have an effect anymore. But we are planning on reintroducing the functionality again soon.
HCookie
commented
Mar 18, 2026
tweska
approved these changes
Mar 18, 2026
Co-authored-by: Harrison Cook <Harrison.cook@ecmwf.int>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #250 +/- ##
========================================
Coverage 56.35% 56.35%
========================================
Files 321 321
Lines 21141 21141
Branches 1679 1679
========================================
Hits 11915 11915
Misses 9226 9226 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c0dab41 to
b7bc29b
Compare
dsarmany
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed geo_from_atlas and cached fields from EncodeMTG class.
Closes #249
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-250