Fix scaling of missing values in encode-mtg2 action#248
Draft
Fix scaling of missing values in encode-mtg2 action#248
Conversation
Missing values should not be scaled
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #248 +/- ##
===========================================
- Coverage 55.81% 55.80% -0.01%
===========================================
Files 325 325
Lines 21372 21373 +1
Branches 1692 1691 -1
===========================================
- Hits 11928 11927 -1
- Misses 9444 9446 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HCookie
previously approved these changes
Mar 13, 2026
Member
HCookie
left a comment
HCookie
left a comment
There was a problem hiding this comment.
Thanks, with this and a key update, works for me
| eckit::mpi::setCommDefault("self"); | ||
| job.execute(input, output); | ||
| eckit::mpi::setCommDefault(originalComm.name().c_str()); | ||
| md.set<std::int64_t>("misc-globalSize", outData.size()); |
Contributor
There was a problem hiding this comment.
This is a breaking API change for Fesom and Nemo and should be done very carefully because it does require changes to those codes again (and the last commits that we have done there was to introduce misc-)
stefaniereuter
requested changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips missing values in the scaling logic in the encode-mtg2 action to be consistent with the scale action.
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-248