Open
Conversation
tweska
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #181 +/- ##
===========================================
- Coverage 62.61% 62.34% -0.27%
===========================================
Files 303 303
Lines 11554 11603 +49
Branches 1029 1037 +8
===========================================
Hits 7234 7234
- Misses 4320 4369 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dsarmany
force-pushed
the
feature/mars2grib-ocean
branch
from
d4d7d69 to
f7e0b9b
Compare
dsarmany
requested changes
Mar 15, 2026
| DEF(LevelType::OceanSurfaceToBottom, "oceanSurfaceToBottom"); | ||
| DEF(LevelType::LakeBottom, "lakeBottom"); | ||
| DEF(LevelType::MixingLayer, "mixingLayer"); | ||
| DEF(LevelType::OceanModel, "oceanModel"); |
Contributor
There was a problem hiding this comment.
I think we will need to introduce some additional logic for the levtype=o3d fields (oceanModel and oceanModelLayer) to set the vertical information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for ORCA grids in the representation concept and adds level mappings required to encode ocean fields.
This PR is meant to be used with these changes in MultIO: ecmwf/multio#247