Open
Conversation
This comment has been minimized.
This comment has been minimized.
Test Results131 tests 131 ✅ 31s ⏱️ Results for commit d0aa2cc. ♻️ This comment has been updated with latest results. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
/license-check |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
.github/workflows/quality.yml
Outdated
| - name: Eslint | ||
| run: cd web/textviewer && npm run lint | ||
|
|
||
| test-siteplan: |
Contributor
There was a problem hiding this comment.
@mariusheine i think, we should make own workflow for all testing, also swtbot and this
Contributor
Author
There was a problem hiding this comment.
@TruongQuangSB Yeah good idea. I will adjust the workflows
Contributor
Author
There was a problem hiding this comment.
@TruongQuangSB For simplicity I kept the swtbot test in the ci workflow. In my opinion and with all I tried it is not worth the benefit. Maybe we can try again later but for now let's keep it like that. At least I put the siteplan testing into a separate workflow
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.