Add missing indices to message format in ModelAssembler#3877
Merged
trancexpress merged 2 commits intoeclipse-platform:masterfrom Apr 9, 2026
Merged
Add missing indices to message format in ModelAssembler#3877trancexpress merged 2 commits intoeclipse-platform:masterfrom
trancexpress merged 2 commits intoeclipse-platform:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes fallback logging in ModelAssembler when no LogService/Logger is available by ensuring the message pattern is valid for java.text.MessageFormat, preventing IllegalArgumentException/NumberFormatException and restoring fallback log output.
Changes:
- Add a helper to transform SLF4J-style
{}placeholders into indexed{n}placeholders. - Apply that transformation in the fallback
MessageFormat.format(...)logging path. - Introduce a precompiled regex
Patternfor efficient placeholder replacement.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...les/org.eclipse.e4.ui.workbench/src/org/eclipse/e4/ui/internal/workbench/ModelAssembler.java
Show resolved
Hide resolved
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
trancexpress
force-pushed
the
gh3873
branch
2 times, most recently
from
d8afa3b to
e53c17a
Compare
The fallback logging mechanism in ModelAssembler uses:
java.text.MessageFormat.format(String, Object...)
Supplied message formats bind arguments without an index,
i.e. message formats use "{}" instead of "{n}".
This causes a NFE in MessageFormat.format(),
resulting in no log output in the fallback case.
In the usual case with an available logger, the indices are added by:
com.sun.org.slf4j.internal.Logger.addIndex(String)
This change likewise adds indices to the message format,
for the fallback case.
Fixes: eclipse-platform#3873
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback logging mechanism in
ModelAssembleruses:Supplied message formats bind arguments without an index, i.e. message formats use
{}instead of{n}.This causes a NFE in
MessageFormat.format(),resulting in no log output in the fallback case.
In the usual case with an available logger, the indices are added by:
This change likewise adds indices to the message format, for the fallback case.
Fixes: #3873