Add implementation for isValueObject()#23625
Merged
hangshao0 merged 1 commit intoeclipse-openj9:masterfrom Apr 6, 2026
Merged
Conversation
AditiS11
force-pushed
the
TestJNIIsValueObject
branch
from
9dbb98c to
44c2204
Compare
theresa-m
added
comp:vm
project:valhalla
theresa-m
suggested changes
Apr 1, 2026
|
|
||
| #if defined(J9VM_OPT_VALHALLA_VALUE_TYPES) | ||
| static jboolean JNICALL | ||
| isValueObject(JNIEnv *env, jobject obj) |
Contributor
There was a problem hiding this comment.
I see that new methods are also added to runtime/j9vm31/jnicsup.cpp.
AditiS11
force-pushed
the
TestJNIIsValueObject
branch
from
44c2204 to
c6274cc
Compare
theresa-m
approved these changes
Apr 2, 2026
theresa-m
reviewed
Apr 2, 2026
| ifelse(eval(JAVA_SPEC_VERSION >= 9), 1, ` jobject (JNICALL * GetModule)(JNIEnv *env, jclass clazz);', `dnl') | ||
| ifelse(eval(JAVA_SPEC_VERSION >= 19), 1, ` jboolean (JNICALL * IsVirtualThread)(JNIEnv *env, jobject obj);', `dnl') | ||
| ifelse(eval(JAVA_SPEC_VERSION >= 24), 1, ` jlong (JNICALL *GetStringUTFLengthAsLong)(JNIEnv *env, jstring string);', `dnl') | ||
| #if defined(J9VM_OPT_VALHALLA_VALUE_TYPES) |
Contributor
There was a problem hiding this comment.
I wonder if these c preprocessor directives will work in an m4 file.
Contributor
There was a problem hiding this comment.
m4 will ignore this and this line will appear verbatim in the jdk; it's not likely that users will define J9VM_OPT_VALHALLA_VALUE_TYPES and so this will have no effect. It must be rewritten to use JAVA_SPEC_VERSION or a new name which would need to be added to the m4 command line.
Contributor
There was a problem hiding this comment.
I expect this to be changed to a JAVA_SPEC_VERSION check once Valhalla is released.
Contributor
There was a problem hiding this comment.
In the meantime, we get the following in jni.h:
jboolean (JNICALL * IsVirtualThread)(JNIEnv *env, jobject obj);
jlong (JNICALL *GetStringUTFLengthAsLong)(JNIEnv *env, jstring string);
#if defined(J9VM_OPT_VALHALLA_VALUE_TYPES)
jboolean (JNICALL *IsValueObject)(JNIEnv *env, jobject obj);
#endif /* defined(J9VM_OPT_VALHALLA_VALUE_TYPES) */
};This will not work for the tests renabled in adoptium/aqa-tests#6995.
Contributor
There was a problem hiding this comment.
A minor nit: The new function pointer should be indented like other fields.
Contributor
There was a problem hiding this comment.
@AditiS11 @hangshao0 What is being done about this?
Author
There was a problem hiding this comment.
I thought of adding a new name to the m4 command line. I am still looking into it.
hangshao0
reviewed
Apr 2, 2026
AditiS11
force-pushed
the
TestJNIIsValueObject
branch
from
c6274cc to
8897ec4
Compare
Add implementation for isValueObject(). Returns true if the object class is a valuetype. Signed-off-by: Aditi Srinivas M <Aditi.Srini@ibm.com>
AditiS11
force-pushed
the
TestJNIIsValueObject
branch
from
8897ec4 to
2994112
Compare
Contributor
|
Jenkins test sanity.functional,extended alinuxval jdknext |
hangshao0
approved these changes
Apr 6, 2026
Contributor
|
@AditiS11 please also open a pull request to enable TestJNIIsValueObject. |
AditiS11
pushed a commit
to AditiS11/openj9
that referenced
this pull request
Apr 10, 2026
Add J9VM_OPT_VALHALLA_VALUE_TYPES to m4 command line so that IsValueObject() can be declared for valhalla build. Related: eclipse-openj9#23625 Signed-off-by: Aditi Srinivas M <Aditi.Srini@ibm.com>
AditiS11
pushed a commit
to AditiS11/openj9
that referenced
this pull request
Apr 10, 2026
Add J9VM_OPT_VALHALLA_VALUE_TYPES to m4 command line so that IsValueObject() can be declared conditionally for valhalla build. Related: eclipse-openj9#23625 Signed-off-by: Aditi Srinivas M <Aditi.Srini@ibm.com>
AditiS11
pushed a commit
to AditiS11/openj9
that referenced
this pull request
Apr 11, 2026
Add J9VM_OPT_VALHALLA_VALUE_TYPES to m4 command line so that IsValueObject() can be declared conditionally for valhalla build. Related: eclipse-openj9#23625 Signed-off-by: Aditi Srinivas M <Aditi.Srini@ibm.com>
AditiS11
pushed a commit
to AditiS11/aqa-tests
that referenced
this pull request
Apr 11, 2026
Enable runtime/valhalla/inlinetypes/TestJNIIsValueObject.java Fixed by: eclipse-openj9/openj9#23625
AditiS11
pushed a commit
to AditiS11/openj9
that referenced
this pull request
Apr 13, 2026
Add J9VM_OPT_VALHALLA_VALUE_TYPES to m4 command line so that IsValueObject() can be declared conditionally for valhalla build. Remove incorrect env parameter from IsVirtualThread() and GetStringUTFLengthAsLong(). Related: eclipse-openj9#23625 Signed-off-by: Aditi Srinivas M <Aditi.Srini@ibm.com>
AditiS11
pushed a commit
to AditiS11/openj9
that referenced
this pull request
Apr 13, 2026
Add J9VM_OPT_VALHALLA_VALUE_TYPES to m4 command line so that IsValueObject() can be declared conditionally for valhalla build. Remove incorrect env parameter from IsVirtualThread() and GetStringUTFLengthAsLong(). Related: eclipse-openj9#23625 Signed-off-by: Aditi Srinivas M <Aditi.Srini@ibm.com>
AditiS11
pushed a commit
to AditiS11/openj9-openjdk-jdk.valuetypes
that referenced
this pull request
Apr 14, 2026
Scc uses the wrong class version for migrated value classes. Related: eclipse-openj9/openj9#23625 Signed-off-by: Aditi Srinivas M <Aditi.Srini@ibm.com>
This was referenced Apr 14, 2026
karianna
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Apr 15, 2026
Enable runtime/valhalla/inlinetypes/TestJNIIsValueObject.java Fixed by: eclipse-openj9/openj9#23625 Co-authored-by: Aditi Srinivas M <Aditi.Srini@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add implementation for isValueObject().
Returns true if the object class is a valuetype.
Required for
runtime/valhalla/inlinetypes/TestJNIIsValueObject.java.