Reduce uses of getResolvedMethods#23624
Open
dsouzai wants to merge 4 commits intoeclipse-openj9:masterfrom
Open
Reduce uses of getResolvedMethods#23624dsouzai wants to merge 4 commits intoeclipse-openj9:masterfrom
getResolvedMethods#23624dsouzai wants to merge 4 commits intoeclipse-openj9:masterfrom
Conversation
dsouzai
added
comp:jit
comp:jitserver
Contributor
Author
|
@mpirvu for your review. I'll open the OMR PR once this PR is accepted. Also, this PR did not eliminate all uses of |
mpirvu
reviewed
Apr 1, 2026
This commit refactors getMatchingMethodFromNameAndSignature by adding a new helper method matchedMethod. It also refactors getResolvedMethods to take in an optional parameter methodName; if methodName is NULl then all methods in the class are returned, otherwise only the ones that match the methodName (regardless of signature) are returned. It also adds the new getResolvedMethodForConstructorWithSig query for when only a constructor method is required. Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
dsouzai
force-pushed
the
reduceGetResolvedMethods
branch
from
a536afa to
f25d3de
Compare
Contributor
Author
|
@mpirvu good for review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #23591 for details.