Skip to content

Impl #175 - [Excel Filter] Support handling of collection values #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fipro78 merged 1 commit into from
Jan 5, 2026
Merged

Impl #175 - [Excel Filter] Support handling of collection values #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed api-baseline/org.eclipse.nebula.widgets.nattable.core_2.5.0.202411280718.jar
View file
Open in desktop
Binary file not shown.
Binary file added api-baseline/org.eclipse.nebula.widgets.nattable.core_2.6.0.202509190702.jar
View file
Open in desktop
Binary file not shown.
Binary file removed api-baseline/org.eclipse.nebula.widgets.nattable.extension.e4_2.5.0.202411280718.jar
View file
Open in desktop
Binary file not shown.
Binary file added api-baseline/org.eclipse.nebula.widgets.nattable.extension.e4_2.6.0.202509190702.jar
View file
Open in desktop
Binary file not shown.
Binary file removed ...baseline/org.eclipse.nebula.widgets.nattable.extension.glazedlists_2.5.0.202411280718.jar
View file
Open in desktop
Binary file not shown.
Binary file added ...baseline/org.eclipse.nebula.widgets.nattable.extension.glazedlists_2.6.0.202509190702.jar
View file
Open in desktop
Binary file not shown.
Binary file removed api-baseline/org.eclipse.nebula.widgets.nattable.extension.nebula_2.5.0.202411280718.jar
View file
Open in desktop
Binary file not shown.
Binary file added api-baseline/org.eclipse.nebula.widgets.nattable.extension.nebula_2.6.0.202509190702.jar
View file
Open in desktop
Binary file not shown.
Binary file removed api-baseline/org.eclipse.nebula.widgets.nattable.extension.poi_2.5.0.202411280718.jar
View file
Open in desktop
Binary file not shown.
Binary file added api-baseline/org.eclipse.nebula.widgets.nattable.extension.poi_2.6.0.202509190702.jar
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion org.eclipse.nebula.widgets.nattable.core.feature/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<feature
id="org.eclipse.nebula.widgets.nattable.core.feature"
label="%featureName"
version="2.6.0.qualifier"
version="2.7.0.qualifier"
provider-name="%providerName"
license-feature="org.eclipse.license"
license-feature-version="0.0.0">
Expand Down
2 changes: 1 addition & 1 deletion org.eclipse.nebula.widgets.nattable.core.test/.classpath
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry kind="src" path="src"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11">
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17">
<attributes>
<attribute name="module" value="true"/>
</attributes>
Expand Down
6 changes: 3 additions & 3 deletions org.eclipse.nebula.widgets.nattable.core.test/.settings/org.eclipse.jdt.core.prefs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
eclipse.preferences.version=1
org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
org.eclipse.jdt.core.compiler.codegen.targetPlatform=11
org.eclipse.jdt.core.compiler.codegen.targetPlatform=17
org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
org.eclipse.jdt.core.compiler.compliance=11
org.eclipse.jdt.core.compiler.compliance=17
Copy link
Copy Markdown
Contributor

@JR-1993 JR-1993 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this API-Breaking? Projects on Java 11 cannot upgrade to 2.7.0.

Copy link
Copy Markdown
Contributor Author

@fipro78 fipro78 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes. But people on Java 11 already can't upgrade to 2.6. At least for some of the extensions. Because the dependencies require Java 17, so the extensions require the same. And the same will apply to the core once the dependency to a newer swt version is introduced to support the new scaling API.

org.eclipse.jdt.core.compiler.debug.lineNumber=generate
org.eclipse.jdt.core.compiler.debug.localVariable=generate
org.eclipse.jdt.core.compiler.debug.sourceFile=generate
Expand All @@ -11,7 +11,7 @@ org.eclipse.jdt.core.compiler.problem.enablePreviewFeatures=disabled
org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
org.eclipse.jdt.core.compiler.problem.reportPreviewFeatures=warning
org.eclipse.jdt.core.compiler.release=enabled
org.eclipse.jdt.core.compiler.source=11
org.eclipse.jdt.core.compiler.source=17
org.eclipse.jdt.core.formatter.align_fields_grouping_blank_lines=2147483647
org.eclipse.jdt.core.formatter.align_type_members_on_columns=false
org.eclipse.jdt.core.formatter.alignment_for_additive_operator=16
Expand Down
4 changes: 2 additions & 2 deletions org.eclipse.nebula.widgets.nattable.core.test/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: NatTable Core Tests
Bundle-SymbolicName: org.eclipse.nebula.widgets.nattable.core.test
Bundle-Version: 2.6.0.qualifier
Bundle-Version: 2.7.0.qualifier
Fragment-Host: org.eclipse.nebula.widgets.nattable.core
Bundle-RequiredExecutionEnvironment: JavaSE-11
Bundle-RequiredExecutionEnvironment: JavaSE-17
Import-Package: org.eclipse.core.commands.common,
org.eclipse.nebula.widgets.nattable.dataset;version="1.4.0",
org.eclipse.nebula.widgets.nattable.dataset.car;version="1.5.0",
Expand Down
4 changes: 2 additions & 2 deletions ...eclipse/nebula/widgets/nattable/filterrow/combobox/FilterRowComboBoxDataProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2019, 2024 Dirk Fauth and others.
* Copyright (c) 2019, 2025 Dirk Fauth and others.
*
* This program and the accompanying materials are made
* available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -107,7 +107,7 @@ public int compare(String o1, String o2) {
}
});

this.provider.configureComparator(columnHeaderDataLayer, configRegistry);
this.provider.configureConfigRegistryAccess(columnHeaderDataLayer, configRegistry);

List<?> values = this.provider.collectValues(0);
assertEquals(8, values.size());
Expand Down
2 changes: 1 addition & 1 deletion org.eclipse.nebula.widgets.nattable.core/.classpath
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<classpath>
<classpathentry kind="src" path="src"/>
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-11">
<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17">
<attributes>
<attribute name="module" value="true"/>
</attributes>
Expand Down
6 changes: 3 additions & 3 deletions org.eclipse.nebula.widgets.nattable.core/.settings/org.eclipse.jdt.core.prefs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ org.eclipse.jdt.core.compiler.annotation.nullable=org.eclipse.jdt.annotation.Nul
org.eclipse.jdt.core.compiler.annotation.nullable.secondary=
org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled
org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
org.eclipse.jdt.core.compiler.codegen.targetPlatform=11
org.eclipse.jdt.core.compiler.codegen.targetPlatform=17
org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
org.eclipse.jdt.core.compiler.compliance=11
org.eclipse.jdt.core.compiler.compliance=17
org.eclipse.jdt.core.compiler.debug.lineNumber=generate
org.eclipse.jdt.core.compiler.debug.localVariable=generate
org.eclipse.jdt.core.compiler.debug.sourceFile=generate
Expand Down Expand Up @@ -114,7 +114,7 @@ org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=ignore
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
org.eclipse.jdt.core.compiler.release=enabled
org.eclipse.jdt.core.compiler.source=11
org.eclipse.jdt.core.compiler.source=17
org.eclipse.jdt.core.formatter.align_fields_grouping_blank_lines=2147483647
org.eclipse.jdt.core.formatter.align_type_members_on_columns=false
org.eclipse.jdt.core.formatter.alignment_for_additive_operator=16
Expand Down
Loading