Fix Debug Hover showing SuperClass Field's value in Subclass Field#930
Merged
SougandhS merged 1 commit intoeclipse-jdt:masterfrom Apr 7, 2026
Merged
Fix Debug Hover showing SuperClass Field's value in Subclass Field#930SougandhS merged 1 commit intoeclipse-jdt:masterfrom
SougandhS merged 1 commit intoeclipse-jdt:masterfrom
Conversation
This commit adds an additional computation for finding the subclass class field if superclass has same field as of subclass Fixes : eclipse-jdt#924
| break; | ||
| } | ||
| List<Field> fieldList = ref.allFields(); // Possible sub class fields with same name as of super class | ||
| fieldList.remove(fieldTmp); |
Member
There was a problem hiding this comment.
@SougandhS : This line will cause CME on next iteration if the break at line 287 will be not reached.
You can't modify the list while iterating it, you can only use fields.remove() here
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an additional computation for finding the subclass class field if superclass has same field as of subclass
Fixes : #924
What it does
How to test
Author checklist