Skip to content

Allow access to org.eclipse.jdt.internal.core.util by org.eclipse.jdt.ui#4987

Merged
trancexpress merged 1 commit intoeclipse-jdt:masterfrom
danthe1st:open-messages-to-jdt-ui
Apr 6, 2026
Merged

Allow access to org.eclipse.jdt.internal.core.util by org.eclipse.jdt.ui#4987
trancexpress merged 1 commit intoeclipse-jdt:masterfrom
danthe1st:open-messages-to-jdt-ui

Conversation

@danthe1st
Copy link
Copy Markdown
Contributor

@danthe1st danthe1st commented Apr 5, 2026

What it does

This PR allows the org.eclipse.jdt.ui bundle to access the org.eclipse.jdt.internal.core.util package of org.eclipse.jdt.core. This is used such that JDT-UI can access the content of the messages.properties/Messages class (specifically classfileformat_methoddescriptor which I want to use to identify methods in the disassembly/class file editor) as suggested by @trancexpress in eclipse-jdt/eclipse.jdt.ui#2708 (comment).

This is a precondition to eclipse-jdt/eclipse.jdt.ui#2708.

How to test

Try accessing org.eclipse.jdt.internal.core.util.Messages.classfileformat_methoddescriptor in JDT-UI or try to use eclipse-jdt/eclipse.jdt.ui#2708 / eclipse-jdt/eclipse.jdt.debug#831

Author checklist

@trancexpress
Copy link
Copy Markdown
Contributor

There are some infrastructure problems right now, e.g.:

Caused by: java.io.IOException: Server returned HTTP code: 502 for URL https://download.eclipse.org/eclipse/updates/4.39/R-4.39-202602260420/plugins/org.eclipse.jdt.core.compiler.batch_3.45.0.v20260224-0835.jar

I'm checking build results from the 20260403 build and I also see frequent 502 errors when browsing the files. I guess we wait until the problems pass...

@danthe1st
Copy link
Copy Markdown
Contributor Author

danthe1st commented Apr 5, 2026

There are some infrastructure problems right now

Yeah I noticed that as well (I also saw them a few hours ago) and also mentioned it in the EF IT matrix room.

@danthe1st danthe1st force-pushed the open-messages-to-jdt-ui branch from d29ce74 to 806a6cf Compare April 6, 2026 08:12
@danthe1st danthe1st force-pushed the open-messages-to-jdt-ui branch from 806a6cf to 161c135 Compare April 6, 2026 17:35
@danthe1st
Copy link
Copy Markdown
Contributor Author

I'm checking build results from the 20260403 build and I also see frequent 502 errors when browsing the files. I guess we wait until the problems pass...

It seems to work now.

@trancexpress
Copy link
Copy Markdown
Contributor

@iloveeclipse can we merge this or is this a bad time for changes to JDT core?

@iloveeclipse
Copy link
Copy Markdown
Member

or is this a bad time for changes to JDT core?

Why should it be bad time now?

@trancexpress
Copy link
Copy Markdown
Contributor

Why should it be bad time now?

No idea, that is why I'm asking.

@iloveeclipse
Copy link
Copy Markdown
Member

?
Anyway, if it is OK, just merge.

@trancexpress trancexpress merged commit c735ef4 into eclipse-jdt:master Apr 6, 2026
13 checks passed
@danthe1st danthe1st deleted the open-messages-to-jdt-ui branch April 6, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants