Add colored output for player moves in display_board#11
Open
BDadmehr0 wants to merge 3 commits intoeberjohns:mainfrom
Open
Add colored output for player moves in display_board#11BDadmehr0 wants to merge 3 commits intoeberjohns:mainfrom
BDadmehr0 wants to merge 3 commits intoeberjohns:mainfrom
Conversation
Contributor
BDadmehr0
commented
May 24, 2025
BDadmehr0
commented
- Player X is now shown in bold red
- Player O is now shown in bold blue
- Improves visual clarity and user experience during gamepla
eberjohns
reviewed
May 26, 2025
Owner
eberjohns
left a comment
eberjohns
left a comment
There was a problem hiding this comment.
Hi @BDadmehr0,
This is a great visual improvement.
But, since the terminal clearing is still under debate, it would be ideal if we could split this PR into two separate ones:
- One for color change
- One for cleaning terminal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.