Add alpha PHOENIX support, workflow recipes, instrument readers, and example notebook#3
Open
ytsapras wants to merge 12 commits intoebachelet:masterfrom
Open
Add alpha PHOENIX support, workflow recipes, instrument readers, and example notebook#3ytsapras wants to merge 12 commits intoebachelet:masterfrom
ytsapras wants to merge 12 commits intoebachelet:masterfrom
Conversation
ytsapras
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added an alpha PHOENIX-based fitting path to Spyctres and reorganized the workflow around a clearer separation between generic fitting code, workflow recipes, examples, and smoke tests.
Main additions
Spyctres/recipes.pySpyctres/io.pyexamples/full_spectrum_classification.ipynbREADME.mdValidation
The main validation reference remains the notebook-faithful X-SHOOTER UVB benchmark path (for Gaia21ccu).
The branch also includes a simpler worked notebook example intended as a first-pass PHOENIX classification workflow rather than a final precision analysis.
Notes
Treat this as an alpha implementation for review and feedback, especially on structure, API choices, and what would make the most sense for upstream integration.