Conversation
|
I will automatically update this comment whenever this PR is modified
|
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
Integration tests are failing for reasons unrelated to this PR. |
chuckwondo
left a comment
There was a problem hiding this comment.
Fantastic! Thank you @mfisher87.
Just a comment about cooldown days, and wondering if you have any suggestions for the 2 items that zizmor flagged?
Those are pre-existing issues that I guess zizmor flagged because I touched code around them. I think we should tackle those (and other alerts that Zizmor raised) in separate PRs -- I currently don't have thoughts on how to fix them :D |
|
earthmover's website seems to be down causing the check links failure |
Description
Resolves #902
Zizmor can catch common security issues in GitHub Actions configurations. It reports in the security tab at the top of the repo. For example, a common attack vector is mutable refs used to pin actions, which we do (we use tags and branches, but should use SHAs).
See: https://socket.dev/blog/trivy-under-attack-again-github-actions-compromise
Still, SHAs are not perfectly safe... they come with their own risk thanks to GitHub doing something totally unexpected (and IMO unsafe and uncool).
my/repo@some-shacould refer tosome-shaon a FORK ofmy/repo, e.g.malicious-person/repo@some-sha, and it would still just work despite being absolutely not what you intended or expected. For this reason, we should allow dependabot to update our actions and not trust any incoming PRs that alter SHAs. Thankfully, zizmor can detect this impostor commit pattern!See: https://www.vaines.org/posts/2026-03-24-the-comforting-lie-of-sha-pinning/
Addressed:
This uses the GH Code Scanning interface (see the security tab at the top) to report issues.
https://github.com/earthaccess-dev/earthaccess/security/code-scanning?query=pr%3A1268+is%3Aopen
"Ready for review" checklist
Merge checklist
closes #1)CHANGELOG.mdupdatedREADME.mdupdatedpre-commit.ci autofixif pre-commit is failing)📚 Documentation preview 📚: https://earthaccess--1268.org.readthedocs.build/en/1268/