Add support of files that use implode compression algorythm#37
Add support of files that use implode compression algorythm#37a-sakharov wants to merge 1 commit intoeagleflo:masterfrom
Conversation
…ample, Diablo 2 mpq do that)
|
Thanks for the contribution! This looks like a worthwhile addition. I have mixed feelings about taking in a dependency wrapping C++ code, as previously |
|
@eagleflo |
|
The standard library wrapping C libraries is quite different from third-party modules containing native code. Not having to build anything is a huge simplification.
Python code being slower than native for extracting MPQ files wasn't a problem 15 years ago when I first wrote this, and certainly isn't now with much faster computers. MPQ is an ancient format and the compression algorithms it uses are even more ancient, dating back to late 80s. Writing a pure Python alternative for PKWare DCL could still be a fun exercise. The patent expired in 2010: https://patents.google.com/patent/US5051745A/en. https://github.com/ladislav-zezula/StormLib/blob/master/src/pklib/explode.c is a reference for how StormLib does it. |
Diablo2 use imploded mpq data. This small patch allow to use this lib with Diablo 2 resources.