Replace bootstrap-datetimepicker

[HannesClausnitzer]

fixes #2546

[Copilot]

Pull request overview

This pull request replaces the bootstrap-datetimepicker JavaScript library with native HTML5 date and datetime-local input types. The change modernizes the date/time input handling by using browser-native controls instead of a third-party library, simplifying the codebase and reducing dependencies.

Changes:

• Replaced bootstrap-datetimepicker widgets with HTML5 native date/datetime inputs across all forms
• Removed bootstrap_datetimepicker.html template includes from multiple templates
• Extracted message rendering into a reusable messages.html template
• Updated plain_page templates to include message rendering explicitly

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
evap/staff/templates/staff_semester_import.html	Removed bootstrap_datetimepicker include and additional JavaScript block
evap/staff/templates/staff_evaluation_form.html	Added messages template include for plain_page display
evap/staff/templates/staff_course_copyform.html	Removed bootstrap_datetimepicker include
evap/staff/forms.py	Updated ImportForm, CourseCopyForm, and EvaluationForm with HTML5 date/datetime widgets
evap/rewards/templates/rewards_reward_point_redemption_event_form.html	Removed bootstrap_datetimepicker include
evap/rewards/forms.py	Updated RewardPointRedemptionEventForm with HTML5 date widgets
evap/evaluation/templates/messages.html	Created reusable messages display template
evap/evaluation/templates/evap_evaluation_edit_js.html	Removed bootstrap_datetimepicker include
evap/evaluation/templates/base.html	Removed bootstrap_datetimepicker CSS and extracted messages to separate template
evap/contributor/forms.py	Updated EvaluationForm widgets (contains bug - incorrect widget type)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[hansegucker]

Also, the file evap/static/js/bootstrap-datetimepicker.min.js still exists.

But apart from that, this looks very good!

[niklasmohrin]

There are also still adjustments in _adjustments.scss for the bootstrap datetimepicker

[niklasmohrin]

Very cool!

We still mention bootstrap-datetimepicker in license.md and the places that are listed in the other comments

[janno42]

It would be nice to open the picker once the field receives focus.

Also, please investigate if we can force the date and time format to be our default format YYYY-MM-DD HH:mm.

[HannesClausnitzer]

So it seems the native datetime-picker in firefox and chromium doesn't meet our needs, as it doesn't support setting the locale and gives a few focus issues (when the date picker is shown, nothing can be typed into the input field).
I have found a different alternative to the bootstrap-datetimepicker that is quite similar but doesn't use jQuery:
https://github.com/Eonasdan/tempus-dominus/
You can try it out here:
https://getdatepicker.com/6/repl.html
What do you think about this? Would it be worth it implementing this?

[richardebeling]

I'll re-mark as draft, if I recall correctly, we decided that a native HTML datetime-local input isn't viable because we had at least one scenario where Firefox would render the time with AM/PM although we didn't want it to (@janno42 right?)

[niklasmohrin]

I am very much pro vanilla inputs, if we can get it to work. However, if not, then I guess switching to this tempus dominus thing is still better what we currently have. Both with this or with our current version of datepicker, we don't get support from anyone, but at least dominus lets us get rid of jquery. Based on the Latin name, we should do a quick background check on whether the creator is a nutcase before associating our project with theirs. Update: Richard and I did some digging, nothing worrying turned up

But before that, let's document here when exactly the plain browser things fail us