Skip to content

fix: suppress autoCorrect & disable activist registry for now#363

Merged
jakehobbs merged 1 commit intomainfrom
jake/disable-registry-supress-autocomplete
May 7, 2026
Merged

fix: suppress autoCorrect & disable activist registry for now#363
jakehobbs merged 1 commit intomainfrom
jake/disable-registry-supress-autocomplete

Conversation

@jakehobbs
Copy link
Copy Markdown
Member

@jakehobbs jakehobbs commented May 7, 2026

Summary by CodeRabbit

  • New Features

    • Introduced feature flag to control activist registry functionality (currently disabled).
  • Improvements

    • Disabled automatic text assistance features in suggestion input, including spell-check, auto-correct, and auto-capitalize.

Copilot AI review requested due to automatic review settings May 7, 2026 03:15
@jakehobbs jakehobbs requested a review from alexsapps as a code owner May 7, 2026 03:15
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e0df6412-082a-4512-8ad9-e52ad3c66479

📥 Commits

Reviewing files that changed from the base of the PR and between c802aaa and 95609e7.

📒 Files selected for processing (2)
  • frontend-v2/src/app/(authed)/events/activist-storage.ts
  • frontend-v2/src/app/(authed)/events/suggestion-input.tsx

📝 Walkthrough

Walkthrough

The PR introduces a feature flag to conditionally gate the activist registry storage backend and disables browser text-assistance features (autocorrect, autocapitalize, spellcheck) on the suggestion input component.

Changes

Activist Storage Feature Flag

Layer / File(s) Summary
Feature Flag Definition
frontend-v2/src/app/(authed)/events/activist-storage.ts
Module-level constant ENABLE_ACTIVIST_REGISTRY = false gates the activist registry feature.
Early Return Guard
frontend-v2/src/app/(authed)/events/activist-storage.ts
getActivistStorage returns undefined immediately when the feature flag is disabled, before any IndexedDB operations.

Suggestion Input Text Assistance Disabling

Layer / File(s) Summary
Input Props
frontend-v2/src/app/(authed)/events/suggestion-input.tsx
Input component receives autoCorrect="off", autoCapitalize="off", and spellCheck={false} to suppress browser text corrections.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • dxe/adb#310: Refactored ActivistRegistry to decouple storage creation; this PR's feature flag for getActivistStorage further controls when storage is accessed.
  • dxe/adb#358: Directly modifies the same getActivistStorage behavior that this PR gates behind the new ENABLE_ACTIVIST_REGISTRY flag.
  • dxe/adb#315: Introduced the SuggestionInput component; this PR disables its native text-assistance features.

Poem

🐰 A flag guards the registry's door,
While inputs shush their spell-check roar.
Simple toggles, clean and neat,
Make the feature flow complete! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jake/disable-registry-supress-autocomplete

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jakehobbs jakehobbs merged commit d0f620f into main May 7, 2026
3 of 4 checks passed
@jakehobbs jakehobbs deleted the jake/disable-registry-supress-autocomplete branch May 7, 2026 03:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts UX and feature behavior in the authed Events area by (1) explicitly disabling browser text-correction features on the suggestion input, and (2) turning off the activist registry’s IndexedDB-backed storage path.

Changes:

  • Add autoCorrect, autoCapitalize, and spellCheck props to the SuggestionInput’s underlying <input>.
  • Introduce a module-level flag that disables the activist registry storage lookup by short-circuiting getActivistStorage().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
frontend-v2/src/app/(authed)/events/suggestion-input.tsx Disables browser autocorrect/capitalization/spellcheck on the suggestion input.
frontend-v2/src/app/(authed)/events/activist-storage.ts Disables the IndexedDB activist storage by gating getActivistStorage() behind a constant flag.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend-v2/src/app/(authed)/events/suggestion-input.tsx
Comment thread frontend-v2/src/app/(authed)/events/activist-storage.ts
onBlur={handleBlur}
autoComplete={autoComplete}
autoCorrect="off"
autoCapitalize="off"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants