Fix BlockSampler validation of a graph with self edges#70
Open
ALVIN-YANG wants to merge 1 commit intodwavesystems:mainfrom
Open
Fix BlockSampler validation of a graph with self edges#70ALVIN-YANG wants to merge 1 commit intodwavesystems:mainfrom
ALVIN-YANG wants to merge 1 commit intodwavesystems:mainfrom
Conversation
Collaborator
|
Hi @ALVIN-YANG thanks for the quick PR!! What do you think of making this validation at the GRBM level instead? Briefly, |
Collaborator
|
Hey @ALVIN-YANG , just want to check in on this. Can you apply your fix at the GRBM level? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69
When
BlockSampleris instantiated on a graph that has self edges,_valid_colouringincorrectly returnsFalsebecause a node always shares a color with itself. This PR updates the validation logic to ignore self edges.