Skip to content

Get classloader resources #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vitalii-honchar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Get classloader resources #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7217d37
Add methods for get classloader resources
vitalii-honchar Feb 25, 2017
cbd8e35
Merge branch 'test'
vitalii-honchar Feb 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions org.kevoree.kcl/src/main/java/org/kevoree/kcl/api/FlexyClassLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import java.io.File;
import java.io.IOException;
import java.net.URL;
import java.util.List;

/**
Expand All @@ -25,4 +26,7 @@ public abstract class FlexyClassLoader extends ClassLoader {

public abstract List<FlexyClassLoader> getSubClassLoaders();

public abstract List<URL> getClassLoaderResources();

public abstract List<URL> getAllResources();
}
2 changes: 2 additions & 0 deletions org.kevoree.kcl/src/main/java/org/kevoree/kcl/api/IndexDB.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,6 @@ public interface IndexDB {

public boolean contains(String name);

List<URL> getResources();

}
14 changes: 14 additions & 0 deletions org.kevoree.kcl/src/main/java/org/kevoree/kcl/impl/FlexyClassLoaderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,4 +527,18 @@ public List<FlexyClassLoaderImpl> graphResourcesOwnerResolution(KlassLoadRequest
return result;
}

@Override
public List<URL> getClassLoaderResources() {
return classpathResources.getResources();
}

@Override
public List<URL> getAllResources() {
List<URL> allResources = new ArrayList<URL>();
for (FlexyClassLoader classLoader : subClassLoaders) {
allResources.addAll(classLoader.getAllResources());
Copy link
Copy Markdown
Owner

@dukeboard dukeboard Feb 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we have a risk of loop. FlexyClassLoader are linked using graph topology.
Therefore, the resolution should leverage a loop-breaking solution (usually with a map of already traversed FCL). This is the only potential problem is saw in the code.

}
allResources.addAll(getClassLoaderResources());
return allResources;
}
}
8 changes: 8 additions & 0 deletions org.kevoree.kcl/src/main/java/org/kevoree/kcl/impl/JarIndexDB.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ public List<URL> get(String name) {
return jarContentURLs.get(name);
}

@Override
public List<URL> getResources() {
List<URL> result = new ArrayList<URL>();
for (List<URL> list : jarContentURLs.values()) {
result.addAll(list);
}
return result;
}

public void loadJar(JarFile jarInput, File origin) throws IOException {
final Enumeration<JarEntry> entries = jarInput.entries();
Expand Down