Updated structure, new features, under a Jekyll template#21
Updated structure, new features, under a Jekyll template#21DevPranjal wants to merge 2 commits intodsgiitr:mainfrom
Conversation
AnirudhDagar
left a comment
There was a problem hiding this comment.
@DevPranjal I made a cursory pass on this PR. Thanks a lot for taking the pain to set up everything with the website. Using JustTheDocs is a nice choice IMO (love the rendered website).
One thing that I'd suggest is to not push anything that is generated using jekyll on the main branch. Instead, we should have a simple gh-action to generate and build, for example, the _site contents on every commit and PR at a different branch say "gh-pages" or something else. This is easy to do and should not be very tough since you have already done all the heavy lifting. Maybe take a look at dsgiitr/website for some inspiration on how it should be set up. Then we add _site dir to .gitignore so that those changes are never pushed accidentally even after local build changes.
I've also made a few very small comments, please take a look.
If you'd like, we can first merge this PR after you remove the generated files from the PR and then you can later send another PR for setting up the gh-actions on main as well as CI on PRs for previews etc. to deploy the website.
Overall this is looking in great shape. Great work!
| @@ -0,0 +1 @@ | |||
| # Put your questions here: | |||
There was a problem hiding this comment.
This line is fine but i think there is a typo in the name of the file, should be rl.yml
| # in the templates via {{ site.myvariable }}. | ||
|
|
||
| title: ML Questions | ||
| email: your-email@example.com |
There was a problem hiding this comment.
| email: your-email@example.com | |
| email: dsg@iitr.ac.in |
| twitter_username: jekyllrb | ||
| github_username: jekyll |
|
Also, why is |
|
Thanks for the review! I have addressed the queries below:
|
|
I think you forgot to push the commits @DevPranjal |
Apologies for a large PR. Forgot to add
_siteinto.gitignorefor the first commit.Preview: https://devpranjal.github.io/ML-InterviewQs/
Everything is now under a website! Since we do not have Github Actions currently, we will be able to setup the website under the dsgiitr domain only after the PR is merged.
This will also provide a base for further contributions, given that Hacktoberfest is getting closer.