Skip to content

Updated 'drevops/behat-steps' to 3.8.0 and 'drupal/drupal-extension' to v6 alpha.#170

Merged
AlexSkrypnyk merged 8 commits into
developfrom
feature/update-behat-deps
May 10, 2026
Merged

Updated 'drevops/behat-steps' to 3.8.0 and 'drupal/drupal-extension' to v6 alpha.#170
AlexSkrypnyk merged 8 commits into
developfrom
feature/update-behat-deps

Conversation

@AlexSkrypnyk
Copy link
Copy Markdown
Member

@AlexSkrypnyk AlexSkrypnyk commented May 9, 2026

Summary

Updates drevops/behat-steps from 3.7.0 to 3.8.0, which migrated the library to drupal/drupal-extension v6.0.0-alpha1 and drupal/drupal-driver v3.0.0-alpha1 as part of behat-steps#631 (release notes). The BigPipeTrait was removed upstream in 3.8.0, so its import and usage have been dropped from FeatureContext.php. The per-package @alpha constraint pattern (e.g. ^6.0@alpha) was used in composer.json to keep the project-wide minimum-stability: stable.

Changes

composer.json

  • Bumped drevops/behat-steps from ^3.7.0 to ^3.8.0
  • Bumped drupal/drupal-extension from ^5.3.3 to ^6.0@alpha
  • Added new direct dependency drupal/drupal-driver at ^3.0@alpha

composer.lock

  • drevops/behat-steps: 3.7.0 -> 3.8.0
  • drupal/drupal-driver: v2.4.3 -> v3.0.0-alpha1
  • drupal/drupal-extension: v5.3.3 -> v6.0.0-alpha1
  • symfony/browser-kit: v7.4.8 -> v8.0.8
  • symfony/css-selector: v7.4.8 -> v7.4.9
  • symfony/http-client: v6.4.36 -> v6.4.37

tests/behat/bootstrap/FeatureContext.php

  • Removed DrevOps\BehatSteps\Drupal\BigPipeTrait import and its use statement (trait was deleted upstream in behat-steps 3.8.0)

Summary by CodeRabbit

  • Chores

    • Updated development dependencies to newer versions.
    • Removed an unused testing trait from the test harness.
  • Tests

    • Renamed Behat region mapping key and restructured message selector configuration.
    • Standardized many feature scenarios to use explicit "the following … content"/"content with fields" phrasing.
    • Adjusted scenario steps, data table formats, link field handling, and assertions (including form-field presence/absence checks).

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Bump Behat dev dependencies, remove BigPipeTrait from FeatureContext, rename DrupalExtension layout key and restructure message selectors in behat.yml, and convert many Behat feature fixture steps to table-driven wording and adjust some assertions/fields.

Changes

Behat Testing Dependencies and Test Code Adaptation

Layer / File(s) Summary
Dependency Version Constraints
composer.json
drevops/behat-steps^3.8.0; drupal/drupal-extension^6.0@alpha; adjust drupal/drupal-driver alpha constraint block.
Test Bootstrap
tests/behat/bootstrap/FeatureContext.php
Remove DrevOps\BehatSteps\Drupal\BigPipeTrait import and use BigPipeTrait; from FeatureContext.
Behat Config
behat.yml
Rename DrupalExtension layout mapping key region_mapregions; replace individual message selector keys with a consolidated messages mapping (default, error, success, warning).
Behat feature steps
tests/behat/features/*
Update many feature Background/setup steps to use “the following ... content” / “with fields” phrasing; restructure some list-item link columns into field_c_p_link:title and field_c_p_link:uri; change some assertions wording; minor whitespace reformatting in one Drush scenario.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: updating drevops/behat-steps to 3.8.0 and drupal/drupal-extension to v6 alpha, which align with the primary dependency updates in composer.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/update-behat-deps

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

This comment has been minimized.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.73%. Comparing base (7c34216) to head (d04ec80).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #170   +/-   ##
========================================
  Coverage    87.73%   87.73%           
========================================
  Files           11       11           
  Lines          163      163           
========================================
  Hits           143      143           
  Misses          20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/behat/features/paragraph_civictheme_manual_list_fields.feature`:
- Around line 25-28: The non-required assertion uses a malformed CSS selector
with an extra closing bracket inside the name attribute; find the string
"[name='field_c_n_components[0][subform][field_c_p_title][0][value]]'].required"
in the feature and remove the extra ] so the selector becomes
"[name='field_c_n_components[0][subform][field_c_p_title][0][value]'].required",
preserving the .required suffix.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c6dc9444-5cb7-4365-8590-cb1e37e8e58a

📥 Commits

Reviewing files that changed from the base of the PR and between 85e17fa and 8cbc9c0.

📒 Files selected for processing (4)
  • behat.yml
  • tests/behat/features/feed.feature
  • tests/behat/features/paragraph_civictheme_manual_list_fields.feature
  • tests/behat/features/paragraph_civictheme_manual_list_render.feature

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@AlexSkrypnyk AlexSkrypnyk temporarily deployed to PR-170 May 9, 2026 12:01 Inactive
@github-actions

This comment has been minimized.

@AlexSkrypnyk AlexSkrypnyk temporarily deployed to PR-170 May 9, 2026 12:09 Inactive
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

Code coverage (threshold: 80%)

  Classes: 50.00% (5/10)
  Methods: 73.91% (17/23)
  Lines:   92.88% (313/337)
Per-class coverage
Drupal\do_feed\FeedUrlBuilder
  Methods: 100.00% ( 4/ 4)   Lines: 100.00% ( 18/ 18)
Drupal\do_feed\Form\FeedSettingsForm
  Methods: 100.00% ( 4/ 4)   Lines: 100.00% ( 15/ 15)
Drupal\do_feed\Hook\EntityDeleteHook
  Methods:  50.00% ( 1/ 2)   Lines:  92.31% ( 12/ 13)
Drupal\do_feed\Hook\EntityPresaveHook
  Methods: 100.00% ( 4/ 4)   Lines: 100.00% ( 54/ 54)
Drupal\do_feed\Hook\PreprocessParagraphHook
  Methods: 100.00% ( 2/ 2)   Lines: 100.00% ( 14/ 14)
Drupal\do_feed\Hook\PreprocessViewsViewRowRssHook
  Methods: 100.00% ( 1/ 1)   Lines: 100.00% (  3/  3)
Drupal\do_feed\Hook\ViewsPreViewHook
  Methods:  50.00% ( 1/ 2)   Lines:  96.43% ( 27/ 28)

@AlexSkrypnyk AlexSkrypnyk merged commit f2b0091 into develop May 10, 2026
8 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/update-behat-deps branch May 10, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants