Updated 'drevops/behat-steps' to 3.8.0 and 'drupal/drupal-extension' to v6 alpha.#170
Conversation
…-extension' v6.0.0-alpha1.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughBump Behat dev dependencies, remove BigPipeTrait from FeatureContext, rename DrupalExtension layout key and restructure message selectors in behat.yml, and convert many Behat feature fixture steps to table-driven wording and adjust some assertions/fields. ChangesBehat Testing Dependencies and Test Code Adaptation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #170 +/- ##
========================================
Coverage 87.73% 87.73%
========================================
Files 11 11
Lines 163 163
========================================
Hits 143 143
Misses 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tension v6 patterns.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…age selectors for v6.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/behat/features/paragraph_civictheme_manual_list_fields.feature`:
- Around line 25-28: The non-required assertion uses a malformed CSS selector
with an extra closing bracket inside the name attribute; find the string
"[name='field_c_n_components[0][subform][field_c_p_title][0][value]]'].required"
in the feature and remove the extra ] so the selector becomes
"[name='field_c_n_components[0][subform][field_c_p_title][0][value]'].required",
preserving the .required suffix.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c6dc9444-5cb7-4365-8590-cb1e37e8e58a
📒 Files selected for processing (4)
behat.ymltests/behat/features/feed.featuretests/behat/features/paragraph_civictheme_manual_list_fields.featuretests/behat/features/paragraph_civictheme_manual_list_render.feature
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…click flow incompatible with v6 BigPipe).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 80%) Per-class coverage |
Summary
Updates
drevops/behat-stepsfrom 3.7.0 to 3.8.0, which migrated the library todrupal/drupal-extensionv6.0.0-alpha1 anddrupal/drupal-driverv3.0.0-alpha1 as part of behat-steps#631 (release notes). TheBigPipeTraitwas removed upstream in 3.8.0, so its import and usage have been dropped fromFeatureContext.php. The per-package@alphaconstraint pattern (e.g.^6.0@alpha) was used incomposer.jsonto keep the project-wideminimum-stability: stable.Changes
composer.jsondrevops/behat-stepsfrom^3.7.0to^3.8.0drupal/drupal-extensionfrom^5.3.3to^6.0@alphadrupal/drupal-driverat^3.0@alphacomposer.lockdrevops/behat-steps: 3.7.0 -> 3.8.0drupal/drupal-driver: v2.4.3 -> v3.0.0-alpha1drupal/drupal-extension: v5.3.3 -> v6.0.0-alpha1symfony/browser-kit: v7.4.8 -> v8.0.8symfony/css-selector: v7.4.8 -> v7.4.9symfony/http-client: v6.4.36 -> v6.4.37tests/behat/bootstrap/FeatureContext.phpDrevOps\BehatSteps\Drupal\BigPipeTraitimport and itsusestatement (trait was deleted upstream in behat-steps 3.8.0)Summary by CodeRabbit
Chores
Tests