Conversation
sauterl
left a comment
There was a problem hiding this comment.
Hi @Benyeemin
First of all, thank you for your work and effort you put into the new viewer.
I do like the idea of a more flexible setup.
There are some minor changes I'd like you to do ahead of merging. Since I do not have the opportunity to actually run DRES properly, I simply assume that it does work as intended.
Could you please also add a couple of screenshots to this MR, such that it is clear what happens from a user's perspective? Those screenshots then could be passed on to the wiki. Speaking of which: Do you plan to update the wiki page accordingly?
frontend/src/app/viewer/leaderboard-viewer/leaderboard-viewer.component.scss
Outdated
Show resolved
Hide resolved
frontend/src/app/viewer/compact-score-graph/compact-score-graph.component.html
Outdated
Show resolved
Hide resolved
|
I am sorry, I didn't see the last change request, so I fixed it in the last commit. |
sauterl
left a comment
There was a problem hiding this comment.
Thank you for the quick reaction to the review. I have seen some screenshots before and am glad that you provided some here.
Again, thanks for your work, this looks good to me.



UI enhancements for the competition viewer, focusing on scalability for larger runs.
Changes
New Viewer Components
The following components are implemented and can be selected in the viewer (not replacing the original components by default):
Viewer Layout Presets
To help with setting up a layout, the viewer now has the option to select a preset (next to the component selection button), instead of manually changing each component. Selecting a preset changes each component to the one specified by it.
Error Dialog Compilation Flag
Added a
showErrorPopupsboolean to theenvironmentandenvironment.prodconfigurations. This flag controls whether theErrorDialogServicedisplays the error passed to it or only logs it into the browser console. Since the error popups block the screen of the viewer and there are errors during normal runs of the competitions, this behavior is not desirable for the production environment.