Conversation
Reviewer flagged: laravel/helpers was relied on transitively via df-core but should be declared explicitly since this package's src/ uses array_get and array_except directly. Also align mockery/nunomaduro-collision to match df-system/df-user require-dev for consistency across foundation tier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Laravel 13 compatibility upgrade for df-database. Composer-only dep matrix bump.
Part of the Laravel 11→13 upgrade campaign. Pilot: dreamfactorysoftware/df-core#162. df-database is the base for 9+ DB connector packages — public API surface is preserved (zero src/ changes).
Changes
Two commits:
Laravel 13 compatibility— composer.json:php → ^8.3,require-dev: laravel/framework ^13.7, phpunit ^11.5.3, orchestra/testbench ^11.0;.gitignore:.phpunit.result.cacheAddress review: explicit laravel/helpers + align dev tooling— addedlaravel/helpers: ^1.8to production require (df-database has 339+array_getand 9array_exceptcall sites — now declared explicitly rather than relying on transitive resolution via df-core); alignedmockery: ^1.6andnunomaduro/collision: ^8.6in require-dev with df-system / df-user.Test plan
composer validate --strict— validcomposer installresolves L13.7.0 + phpunit 11.5.55 + testbench v11.1.0 cleanly with df-core path-repophp -lclean over 30 PHP files./vendor/bin/phpunit—OK (13 tests, 26 assertions)— security regression suite (DbFunctionTemplateTest) green under PHPUnit 11.5 + L13.7Notes
origin/mastersoclaude-virtual-rel-transactions(active in-flight virtual relation transactions work) is preserved untouched.