[dotnet-svcutil] Fix MessageContract member name collision for "System" #5911
Open
imcarolwang wants to merge 1 commit intodotnet:mainfrom
Open
[dotnet-svcutil] Fix MessageContract member name collision for "System" #5911imcarolwang wants to merge 1 commit intodotnet:mainfrom
imcarolwang wants to merge 1 commit intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5910:
This PR applies the same naming-fix pattern from the previous related issue #4215 to the MessageContract path. When a MessageContract type member is named System, the generated C# member identifier is now safely renamed, while preserving the original wire name in attributes. A regression test was added to cover this scenario.
Using global:: everywhere could help with broader cases (for type named System), but that would require wider codegen changes and make generated code noisier. For this fix, we kept the scope targeted and consistent with the existing naming-collision approach. A broader global:: strategy can be tracked separately if needed.