Set deterministic FileVersion for Newtonsoft.Json to match MSFT-shipped package#1613
Open
mthalman wants to merge 1 commit intodotnet:mainfrom
Open
Set deterministic FileVersion for Newtonsoft.Json to match MSFT-shipped package#1613mthalman wants to merge 1 commit intodotnet:mainfrom
mthalman wants to merge 1 commit intodotnet:mainfrom
Conversation
…ed package The upstream Newtonsoft.Json build computes a date-based FileVersion revision via PowerShell. Since source-build uses dotnet pack without this override, the 4th component defaulted to 0. This adds FileVersionRevision and composes the FileVersion to match the official package. Also updates the FileVersionRevision and ReleaseVersion validation tests to discover package IDs from build output instead of requiring explicit properties, and adds a new test that verifies release versions match built package output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream Newtonsoft.Json build computes a date-based FileVersion revision via PowerShell. Since source-build uses dotnet pack without this override, the 4th component defaulted to 0. This adds FileVersionRevision and composes the FileVersion to match the official package.
Also updates the FileVersionRevision and ReleaseVersion validation tests to discover package IDs from build output instead of requiring explicit properties, and adds a new test that verifies release versions match built package output.
Fixes dotnet/source-build#5511