Expose HTTP.sys kernel response buffering control for HttpListener on Windows#124720
Open
karimsalem1 wants to merge 1 commit intodotnet:mainfrom
Open
Expose HTTP.sys kernel response buffering control for HttpListener on Windows#124720karimsalem1 wants to merge 1 commit intodotnet:mainfrom
karimsalem1 wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Member
AppContext switches are de-facto public APIs, just a different kind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an opt-in
AppContextswitch to enable kernel response buffering in HttpListener (Windows implementation only). When enabled, the flagHTTP_SEND_RESPONSE_FLAG_BUFFER_DATAis set on all calls toHttpSendHttpResponseandHttpSendResponseEntityBody(consistent with Win32 docs). This mirrors the behavior for setting theHttpSysOptions.EnableKernelResponseBufferingflag in ASP.NET HTTP.sys code.Motivation in issue #123425.
Sample usage:
Notes:
HttpListenerandHttpResponseStream, and consolidated existing Windows-only tests there for consistency.TODO: add manual validation repro showing perf improvements using this feature
Thanks @ManickaP for all the help!