Skip to content

Changed non-units to follow the UCUM standard and OTel convention#53398

Open
gfoidl wants to merge 2 commits intodotnet:mainfrom
gfoidl:patch-4
Open

Changed non-units to follow the UCUM standard and OTel convention#53398
gfoidl wants to merge 2 commits intodotnet:mainfrom
gfoidl:patch-4

Conversation

@gfoidl
Copy link
Copy Markdown
Member

@gfoidl gfoidl commented Apr 28, 2026

Summary

Specifically changed {hats} to be {hat} according Instrument units:

All non-units that use curly braces to annotate a quantity need to match the grammatical number of the quantity it represent. For example if measuring the number of individual requests to a process the unit would be {request}, not {requests}.

The same applies to {hat} and the docs should follow best pratices and conventions.


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/metrics-instrumentation.md Creating metrics

Specifically changed `{hats}` to be `{hat}` according [Instrument units](https://opentelemetry.io/docs/specs/semconv/general/metrics/#instrument-units):
> All non-units that use curly braces to annotate a quantity need to match the grammatical number of the quantity it represent. For example if measuring the number of individual requests to a process the unit would be `{request}`, not `{requests}`.

The same applies to `{hat}` and the docs should follow best pratices and conventions.
@gfoidl gfoidl requested review from a team and tommcdon as code owners April 28, 2026 09:41
@dotnetrepoman dotnetrepoman Bot added this to the April 2026 milestone Apr 28, 2026
@dotnet-policy-service dotnet-policy-service Bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Apr 28, 2026
Comment thread docs/core/diagnostics/metrics-instrumentation.md Outdated
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants