Changed non-units to follow the UCUM standard and OTel convention#53398
Open
gfoidl wants to merge 2 commits intodotnet:mainfrom
Open
Changed non-units to follow the UCUM standard and OTel convention#53398gfoidl wants to merge 2 commits intodotnet:mainfrom
gfoidl wants to merge 2 commits intodotnet:mainfrom
Conversation
Specifically changed `{hats}` to be `{hat}` according [Instrument units](https://opentelemetry.io/docs/specs/semconv/general/metrics/#instrument-units):
> All non-units that use curly braces to annotate a quantity need to match the grammatical number of the quantity it represent. For example if measuring the number of individual requests to a process the unit would be `{request}`, not `{requests}`.
The same applies to `{hat}` and the docs should follow best pratices and conventions.
gewarren
approved these changes
Apr 28, 2026
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Specifically changed
{hats}to be{hat}according Instrument units:The same applies to
{hat}and the docs should follow best pratices and conventions.Internal previews