Skip to content

use SpecialFolder.UserProfile instead of USERPROFILE #5741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kasperk81 wants to merge 6 commits into
base: main
Choose a base branch
from
+8 −19
Open

use SpecialFolder.UserProfile instead of USERPROFILE #5741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2aa72a9
use SpecialFolder.UserProfile instead of USERPROFILE
kasperk81 Feb 25, 2026
2e4d664
Update Utilities.cs
kasperk81 Feb 25, 2026
f2a213c
Update TestConfiguration.cs
kasperk81 Feb 26, 2026
8e77ad8
Update Utilities.cs
kasperk81 Feb 26, 2026
f3b6749
Update Utilities.cs
kasperk81 Feb 26, 2026
c9674f1
Fix path combination for UserProfile directory
kasperk81 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/Microsoft.Diagnostics.DebugServices.Implementation/Utilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,16 +281,13 @@ public static Stream TryOpenFile(string path)
/// </summary>
public static string GetDotNetHomeDirectory()
{
string dotnetHome;
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
string basePath = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);
if (!string.IsNullOrEmpty(basePath))
{
dotnetHome = Path.Combine(Environment.GetEnvironmentVariable("USERPROFILE") ?? throw new ArgumentNullException("USERPROFILE environment variable not found"), ".dotnet");
throw new ArgumentNullException("UserProfile directory not found");
}
else
{
dotnetHome = Path.Combine(Environment.GetEnvironmentVariable("HOME") ?? throw new ArgumentNullException("HOME environment variable not found"), ".dotnet");
}
return dotnetHome;

return Path.Combine(basePath, ".dotnet");
}

/// <summary>
Expand Down
14 changes: 3 additions & 11 deletions src/Microsoft.Diagnostics.TestHelpers/TestConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,10 @@ private void ParseConfigFile(string path)
// This emulates that logic so the VS Test Explorer can still run the tests for
// config files that don't set the NugetPackagesCacheDir value (like the SOS unit
// tests).
string nugetPackagesRoot = null;
if (OS.Kind == OSKind.Windows)
string basePath = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);
if (!string.IsNullOrEmpty(basePath))
{
nugetPackagesRoot = Environment.GetEnvironmentVariable("UserProfile");
}
else if (OS.Kind is OSKind.Linux or OSKind.OSX)
{
nugetPackagesRoot = Environment.GetEnvironmentVariable("HOME");
}
if (nugetPackagesRoot != null)
{
nugetPackages = Path.Combine(nugetPackagesRoot, ".nuget", "packages");
nugetPackages = Path.Combine(basePath, ".nuget", "packages");
}
}
// The TargetArchitecture and NuGetPackageCacheDir can still be overridden
Expand Down