-
Notifications
You must be signed in to change notification settings - Fork 108
Add buildcache channel for Build Caching Service runtime resolution #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LoopedBard3
wants to merge
3
commits into
dotnet:main
Choose a base branch
from
LoopedBard3:AddBuildCacheSystemSupportForCrank
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| # Build Cache Service — Requirements for Crank Integration | ||
|
|
||
| ## Context | ||
|
|
||
| Crank (the .NET benchmarking tool) has been updated to support a new `buildcache` channel that downloads pre-built runtime binaries from the Build Cache Service (BCS) instead of resolving versions from VMR/NuGet feeds. This gives per-commit granularity for performance testing and regression bisection. | ||
|
|
||
| The crank-side changes are complete. This document describes what's needed on the BCS/dotnet-performance-infra side to make the integration work end-to-end. | ||
|
|
||
| --- | ||
|
|
||
| ## Requirement 1: Public Blob Access | ||
|
|
||
| **Status:** Already in progress (per prior discussion). | ||
|
|
||
| Crank's BCS client uses unauthenticated HTTP GET requests to download artifacts. The blobs in the `pvscmdupload` storage account's `$web` container need to be publicly readable. | ||
|
|
||
| **URLs crank will hit:** | ||
|
|
||
| ``` | ||
| GET https://pvscmdupload.z22.web.core.windows.net/builds/{repoName}/latest/{branch}/latestBuilds.json | ||
| GET https://pvscmdupload.z22.web.core.windows.net/builds/{repoName}/buildArtifacts/{commitSha}/{configKey}/{artifactFile} | ||
| ``` | ||
|
|
||
| Where: | ||
| - `repoName` = `runtime` (initially; `aspnetcore` in the future) | ||
| - `branch` = e.g., `main`, `release/10.0` | ||
| - `configKey` = e.g., `coreclr_x64_linux`, `coreclr_arm64_windows` | ||
| - `artifactFile` = e.g., `BuildArtifacts_linux_x64_Release_coreclr.tar.gz` | ||
|
|
||
| --- | ||
|
|
||
| ## Requirement 2: Commit Index File (Not Required) | ||
|
|
||
| ~~Originally proposed as a per-branch `commitIndex.json` mapping commits to timestamps.~~ | ||
|
|
||
| **Decision:** Not needed. For the default case, `latestBuilds.json` provides the latest commit. For specific-commit runs (e.g., bisection), users will already know the SHAs — either from git history, GitHub, or a local tool that queries the GitHub API for the commit list. A separate index in BCS would be redundant. | ||
|
|
||
| If automated bisection tooling is built in the future, it can query GitHub directly for ordered commit SHAs and then check BCS blob existence per-commit. | ||
|
|
||
| --- | ||
|
|
||
| ## Requirement 3: latestBuilds.json Compatibility | ||
|
|
||
| **Resolved.** The actual `latestBuilds.json` uses PascalCase (`CommitSha`, `CommitTime`), not snake_case. Crank's parser has been updated to accept both casings for forward compatibility. | ||
|
|
||
| --- | ||
|
|
||
| ## Requirement 4: Artifact Layout Stability | ||
|
|
||
| Crank extracts runtime artifacts using this path convention inside the archive: | ||
|
|
||
| ``` | ||
| microsoft.netcore.app.runtime.{rid}/Release/runtimes/{rid}/lib/net{X}.0/ → managed DLLs | ||
| microsoft.netcore.app.runtime.{rid}/Release/runtimes/{rid}/native/ → native libs | ||
| {rid}.Release/corehost/ → host binaries (dotnet, libhostfxr, libhostpolicy) | ||
| ``` | ||
|
|
||
| Where `{rid}` = `linux-x64`, `linux-arm64`, `win-x64`, etc. | ||
|
|
||
| This layout was confirmed by inspecting `BuildArtifacts_linux_arm64_Release_coreclr.tar.gz`. **If this layout changes in future builds, the crank extraction will break.** Consider treating it as a stable contract or documenting it. | ||
|
|
||
| --- | ||
|
|
||
| ## Nice-to-Have: Artifact Manifest | ||
|
|
||
| A `manifest.json` per commit+config that describes the archive contents would make extraction more robust: | ||
|
|
||
| ``` | ||
| builds/{repoName}/buildArtifacts/{commitSha}/{configKey}/manifest.json | ||
| ``` | ||
|
|
||
| ```json | ||
| { | ||
| "runtimeVersion": "10.0.0-preview.4.26120.3", | ||
| "commitSha": "abc123...", | ||
| "rid": "linux-arm64", | ||
| "managedPath": "microsoft.netcore.app.runtime.linux-arm64/Release/runtimes/linux-arm64/lib/net10.0", | ||
| "nativePath": "microsoft.netcore.app.runtime.linux-arm64/Release/runtimes/linux-arm64/native", | ||
| "corehostPath": "linux-arm64.Release/corehost" | ||
| } | ||
| ``` | ||
|
|
||
| This isn't blocking — crank currently discovers paths by convention — but it would decouple crank from the internal archive layout and make future changes safe. | ||
|
|
||
| --- | ||
|
|
||
| ## Summary | ||
|
|
||
| | # | Requirement | Priority | Blocking? | | ||
| |---|-------------|----------|-----------| | ||
| | 1 | Public blob access | High | Yes — crank can't download without it | | ||
| | 2 | ~~Commit index~~ | N/A | Dropped — users provide SHAs directly or use GitHub | | ||
| | 3 | `latestBuilds.json` field names | N/A | Resolved — crank parser updated to handle PascalCase | | ||
| | 4 | Artifact layout stability | Medium | Not now, but breaking changes would break crank | | ||
| | 5 | Artifact manifest.json | Low | Nice-to-have for robustness | | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc’s example URLs use the blob endpoint with
/$web/..., but the agent default base URL (and client URL construction) uses the static website endpoint (https://pvscmdupload.z22.web.core.windows.net) without/$web. Please align the documented URLs with what the agent actually calls (or clarify which base URL should be configured via--build-cache-base-url).