Fix xharness watchdog process cleanup in apple and android runners#16637
Open
akoeplinger wants to merge 1 commit intodotnet:mainfrom
Open
Fix xharness watchdog process cleanup in apple and android runners#16637akoeplinger wants to merge 1 commit intodotnet:mainfrom
akoeplinger wants to merge 1 commit intodotnet:mainfrom
Conversation
Fixes the noisy error on normal (non-timeout) runs: ./xharness-runner.apple.sh: line 187: 4322 Killed: 9 sleep "$command_timeout" This happened because the watchdog's sleep process was still running when the command finished, and the shell reported its termination. The original code never cleaned up the watchdog since it didn't track its PID. Changes: - Capture the watchdog PID (WATCHDOG_PID) and kill it after the command finishes, then wait on it to suppress the 'Killed' message. - Rename PID to COMMAND_PID for clarity. - Remove the inner '&' inside the watchdog subshell that caused the sleep && kill chain to be double-backgrounded, making the captured PID point to an already-exited subshell instead of the actual sleeper. - Remove the redundant explicit subshell (...) since backgrounding with '&' already implies one.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the noisy error on normal (non-timeout) runs:
This happened because the watchdog's sleep process was still running when the command finished, and the shell reported its termination. The original code never cleaned up the watchdog since it didn't track its PID.
Changes: