Skip to content

Avoid importing SDK for C++ projects #16618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichalPetryka wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

Avoid importing SDK for C++ projects #16618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Microsoft.DotNet.Arcade.Sdk/tools/BuildTasks.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
<Project>

<!-- Import the BundledVersions.props file from SDK to light-up Runtime="NET" task support.
Avoid importing for C++ projects.
Only import when NETCoreSdkBundledVersionsProps is not defined (non SDK style projects).
Remove when https://github.com/dotnet/msbuild/issues/12895 is implemented. -->
<Import Sdk="Microsoft.NET.Sdk" Project="Sdk.BundledVersions.props" Condition="'$(MSBuildRuntimeType)' == 'Full' and '$(NETCoreSdkBundledVersionsProps)' == ''" />
<Import Sdk="Microsoft.NET.Sdk" Project="Sdk.BundledVersions.props" Condition="'$(MSBuildRuntimeType)' == 'Full' and '$(MSBuildProjectExtension)' != '.vcxproj' and '$(NETCoreSdkBundledVersionsProps)' == ''" />
<!-- Set required RuntimeIdentifierGraphPath property for Runtime="NET" support. Remove when
a desktop msbuild (via VS) with https://github.com/dotnet/msbuild/pull/13176 is consumed. -->
<PropertyGroup Condition="'$(MSBuildRuntimeType)' == 'Full' and '$(UsingMicrosoftNETSdk)' != 'true' and '$(RuntimeIdentifierGraphPath)' == ''">
Expand Down
Loading