Support detached signature verification for tars and zips#16574
Open
ellahathaway wants to merge 2 commits intodotnet:mainfrom
Open
Support detached signature verification for tars and zips#16574ellahathaway wants to merge 2 commits intodotnet:mainfrom
ellahathaway wants to merge 2 commits intodotnet:mainfrom
Conversation
ellahathaway
force-pushed
the
signcheck-detached-signature
branch
from
7f43a23 to
2b6ca9c
Compare
Member
Author
|
@mmitche - friendly ping for a review whenever you get a chance :) I'd like to get this in and flowed to the VMR by 10.0 code complete. Thanks! |
mmitche
reviewed
Mar 19, 2026
mmitche
reviewed
Mar 19, 2026
…verifiers The parameter name 'supportsDetachedSignature' implied capability support, but it actually controls whether verifiers look for a detached signature (.sig file) instead of a non-detached signature. Rename to 'signatureIsDetached' to better reflect the semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mmitche
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16249
Adds support for detecting and verifying tars and zips with detached signatures.