DRAFT Pack experiment by mdaigle · Pull Request #3985 · dotnet/SqlClient

mdaigle · 2026-02-25T19:48:50Z

Description

Provide a summary of the changes being introduced. Important topics to cover
include:

Description of the functionality.
API changes, backwards compatibility, deprecations, etc.
Documentation, localization.
Bug fixes.
Code hygiene, refactoring, improvements.
Engineering processes (CI, pipelines, test coverage)

High quality descriptions will lead to a smoother review experience.

Issues

Link to any relevant issues, bugs, or discussions (e.g., Closes #123, Fixes issue #456).

Testing

Describe the automated tests (unit, integration) you created or modified.
Provide justification for any gap in automated testing. List any manual testing
steps that were performed to ensure the changes work.

Guidelines

Please review the contribution guidelines before submitting a pull request:

Copilot

Pull request overview

This PR introduces experimental build infrastructure changes to support packaging Microsoft.Data.SqlClient. The changes modernize the OS targeting logic in the unified source project and introduce a new experimental build file (build2.proj) with packaging targets.

Changes:

Refactored OS targeting in Microsoft.Data.SqlClient.csproj to accept OSGroup from build.proj and support AnyOS stub assemblies
Added build2.proj with experimental build, pack, and test targets for Microsoft.Data.SqlClient and AKV provider
Updated build.proj to use unified MdsSource project instead of separate NetFxDriver/NetCoreDriver ItemGroups

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File	Description
src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj	Refactored TargetOs logic to accept OSGroup parameter; added AnyOS stub assembly generation; restructured output paths to maintain legacy layout compatibility
build2.proj	New experimental build file with BuildMds, PackMds, BuildAkv targets and placeholder test targets
build.proj	Replaced NetFxDriver/NetCoreDriver with unified MdsSource ItemGroup; updated all build targets to pass TargetFrameworks parameter

Copilot · 2026-02-25T19:54:42Z

build2.proj

+        NugetPath
+        Applies to:  Pack* targets
+        Description: Path to folder containing `nuget` binary. Override this if a specific version
+                     is required. Othrwise, this defaults to the `nuget` binary in the PATH


Typo in "Othrwise" should be "Otherwise".

Suggested change

is required. Othrwise, this defaults to the `nuget` binary in the PATH

is required. Otherwise, this defaults to the `nuget` binary in the PATH

Copilot · 2026-02-25T19:54:42Z

build2.proj

+      <!-- Convert more than one whitespace character into one space -->
+      <DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>
+    </PropertyGroup>
+    <Message Text=">>> Packageing MDS via command: $(NugetCommand)" />


Typo in "Packageing" should be "Packaging".

Suggested change

<Message Text=">>> Packageing MDS via command: $(NugetCommand)" />

<Message Text=">>> Packaging MDS via command: $(NugetCommand)" />

Copilot · 2026-02-25T19:54:42Z

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj

+    <OutputPath>$(BinFolder)$(Configuration).$(Platform)/$(AssemblyName)/$(_TfmGroup)/</OutputPath>
+    <IntermediateOutputPath>$(ObjFolder)$(Configuration).$(Platform)/$(AssemblyName)/$(_TfmGroup)/</IntermediateOutputPath>


The OutputPath and IntermediateOutputPath use the $(Platform) property, but Platform is not defined with a default value in this project file. When building directly (e.g., from an IDE without passing Platform explicitly), this could result in an invalid path. Consider adding a default value such as <Platform Condition="'$(Platform)' == ''">AnyCPU</Platform> in a PropertyGroup before these paths are set.

Copilot · 2026-02-25T19:54:42Z

build2.proj

@@ -2,24 +2,56 @@
 <Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">


The PR description is empty and the mentioned issues (#123 about SQL Graph edge pseudo-columns and #456 about UDT buffers) appear to be unrelated to the changes in this PR, which focus on build infrastructure and packaging experiments. The PR description should be filled out to explain the purpose of this experimental build infrastructure, what problems it's trying to solve, and whether build2.proj is intended to replace or supplement build.proj.

Copilot · 2026-02-25T19:54:43Z

build2.proj

+  <!-- TestMds: Runs all test projects for MDS -->
+  <Target Name="TestMds" DependsOnTargets="TestMdsFunctional;TestMdsManual;TestMdsUnit" />
+
+  <!-- TestMdsFunctional: Runs functional tests for MDS -->
+  <Target Name="TestMdsFunctional">
+    <!-- @TODO -->
+  </Target>
+
+  <!-- TestMdsManual: Runs manual tests for MDS -->
+  <Target Name="TestMdsManual">
+    <!-- @TODO -->
+  </Target>
+
+  <!-- TestMdsUnit: Runs unit tests for MDS -->
+  <Target Name="TestMdsUnit">
+    <!-- @TODO -->


The test targets (TestMdsFunctional, TestMdsManual, TestMdsUnit) are not implemented and contain TODO comments. Before this PR is merged, these targets should either be implemented or the TestMds target should be removed/documented as a placeholder for future work.

Suggested change



<Target Name="TestMds" DependsOnTargets="TestMdsFunctional;TestMdsManual;TestMdsUnit" />



<Target Name="TestMdsFunctional">



</Target>



<Target Name="TestMdsManual">



</Target>



<Target Name="TestMdsUnit">





<Target Name="TestMds" DependsOnTargets="TestMdsFunctional;TestMdsManual;TestMdsUnit" />



<Target Name="TestMdsFunctional">

<Message Importance="High"

Text="TestMdsFunctional is currently a placeholder and does not run any functional tests. Override this target to add functional test execution." />

</Target>



<Target Name="TestMdsManual">

<Message Importance="High"

Text="TestMdsManual is currently a placeholder and does not run any manual tests. Override this target to add manual test execution." />

</Target>



<Target Name="TestMdsUnit">

<Message Importance="High"

Text="TestMdsUnit is currently a placeholder and does not run any unit tests. Override this target to add unit test execution." />

Copilot · 2026-02-25T19:54:43Z

build2.proj

+    <PropertyGroup>
+      <NugetCommand>
+        nuget pack &quot;$(MdsNuspecPath)&quot;
+          -OutputDirectory &quot;$(MdsArtifactsPath)&quot;


The property MdsArtifactsPath is referenced but never defined. It should likely be MdsArtifactsFolder instead, which is defined on line 52.

Suggested change

-OutputDirectory "$(MdsArtifactsPath)"

-OutputDirectory "$(MdsArtifactsFolder)"

Copilot · 2026-02-25T19:54:43Z

build2.proj

+          -SymbolPackageFormat snupkg
+      </NugetCommand>
+      <!-- Convert more than one whitespace character into one space -->
+      <DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>


The variable NugetCommand is assigned here but then DotnetCommand is incorrectly used in the whitespace cleanup on line 116. This should be cleaning up NugetCommand instead.

Suggested change

<DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>

<NugetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(NugetCommand), "\s+", " "))</NugetCommand>

…project.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 14 comments.

Copilot · 2026-02-27T00:57:45Z

tools/specs/Microsoft.Data.SqlClient.nuspec

+    <!-- /ref/ ========================================================= -->
+    <!-- @TODO: ref NetFx -->
    <file src="..\..\artifacts\$ReferenceType$\bin\Windows_NT\$Configuration$\Microsoft.Data.SqlClient\ref\net462\Microsoft.Data.SqlClient.dll" target="ref\net462\" exclude="" />
    <file src="..\..\artifacts\$ReferenceType$\bin\Windows_NT\$Configuration$\Microsoft.Data.SqlClient\ref\net462\Microsoft.Data.SqlClient.xml" target="ref\net462\" exclude="" />

-    <!-- ref NetCore for Net 8 -->
+    <!-- @TODO: ref NetCore for Net 8 -->
    <file src="..\..\artifacts\$ReferenceType$\bin\AnyOS\$Configuration$\Microsoft.Data.SqlClient\ref\net8.0\Microsoft.Data.SqlClient.dll" target="ref\net8.0\" exclude="" />
    <file src="..\..\artifacts\$ReferenceType$\bin\AnyOS\$Configuration$\Microsoft.Data.SqlClient\ref\net8.0\Microsoft.Data.SqlClient.xml" target="ref\net8.0\" exclude="" />

-    <!-- ref NetCore for Net 9 -->
+    <!-- @TODO: ref NetCore for Net 9 -->
    <file src="..\..\artifacts\$ReferenceType$\bin\AnyOS\$Configuration$\Microsoft.Data.SqlClient\ref\net9.0\Microsoft.Data.SqlClient.dll" target="ref\net9.0\" exclude="" />
    <file src="..\..\artifacts\$ReferenceType$\bin\AnyOS\$Configuration$\Microsoft.Data.SqlClient\ref\net9.0\Microsoft.Data.SqlClient.xml" target="ref\net9.0\" exclude="" />

-    <!-- ref NetCore for NetStandard2.0 -->
+    <!-- @TODO: ref NetCore for NetStandard2.0 -->
    <file src="..\..\artifacts\$ReferenceType$\bin\AnyOS\$Configuration$\Microsoft.Data.SqlClient\ref\netstandard2.0\Microsoft.Data.SqlClient.dll" target="ref\netstandard2.0\" exclude="" />
    <file src="..\..\artifacts\$ReferenceType$\bin\AnyOS\$Configuration$\Microsoft.Data.SqlClient\ref\netstandard2.0\Microsoft.Data.SqlClient.xml" target="ref\netstandard2.0\" exclude="" />


These /ref/ file entries still use the legacy artifacts\$ReferenceType$\bin\... layout and the $ReferenceType$ token. With the new SDK-style project OutputPath (and build2.proj's nuget pack invocation not passing ReferenceType), these paths/tokens will not resolve and nuget pack will fail. Either update these src= paths to the new artifacts\Microsoft.Data.SqlClient... layout (or wherever ref outputs now land) or ensure the build + pack pipeline still produces and passes the expected $ReferenceType$ structure/property.

Copilot · 2026-02-27T00:57:46Z

tools/specs/Microsoft.Data.SqlClient.nuspec

@@ -154,27 +150,29 @@
    <file src="..\..\artifacts\$ReferenceType$\bin\Windows_NT\$Configuration$.AnyCPU\Microsoft.Data.SqlClient\netfx\net462\zh-Hans\Microsoft.Data.SqlClient.resources.dll" target="lib\net462\zh-Hans\" exclude="" />
    <file src="..\..\artifacts\$ReferenceType$\bin\Windows_NT\$Configuration$.AnyCPU\Microsoft.Data.SqlClient\netfx\net462\zh-Hant\Microsoft.Data.SqlClient.resources.dll" target="lib\net462\zh-Hant\" exclude="" />


The net462 satellite resource src= paths are still pointing at artifacts\$ReferenceType$\bin\Windows_NT\...\netfx\net462\<culture>\.... The updated project output layout writes binaries under artifacts\Microsoft.Data.SqlClient\$(Configuration)\windows_nt\net462\... (with cultures as subfolders), so these file includes likely won't exist and will break packing. Align these resource paths with the actual output directory structure used by the SDK-style project build.

Copilot · 2026-02-27T00:57:46Z

build2.proj

+          -Properties &quot;COMMITID=$(CommitHash);Configuration=$(Configuration);&quot;
+          -Symbols
+          -SymbolPackageFormat snupkg
+      </NugetCommand>
+      <!-- Convert more than one whitespace character into one space -->
+      <DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>


The nuget pack invocation doesn't pass required nuspec properties. The nuspec uses tokens like $ReferenceType$ , $AbstractionsPackageVersion$ , and $LoggingPackageVersion$ ; without supplying these via -Properties, packing will fail (unresolved tokens / missing file paths). Update -Properties to include these values (or remove the tokens from the nuspec if they are no longer needed).

Suggested change

-Properties "COMMITID=$(CommitHash);Configuration=$(Configuration);"

-Symbols

-SymbolPackageFormat snupkg

</NugetCommand>



<DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>

-Properties "COMMITID=$(CommitHash);Configuration=$(Configuration);ReferenceType=$(ReferenceType);AbstractionsPackageVersion=$(AbstractionsPackageVersion);LoggingPackageVersion=$(LoggingPackageVersion);"

-Symbols

-SymbolPackageFormat snupkg

</NugetCommand>



<NugetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(NugetCommand), "\s+", " "))</NugetCommand>

Copilot · 2026-02-27T00:57:46Z

build2.proj

+      <!-- Convert more than one whitespace character into one space -->
+      <DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>
+    </PropertyGroup>
+    <Message Text=">>> Packageing MDS via command: $(NugetCommand)" />


Typo in the message text: "Packageing" should be "Packaging".

Suggested change

<Message Text=">>> Packageing MDS via command: $(NugetCommand)" />

<Message Text=">>> Packaging MDS via command: $(NugetCommand)" />

Copilot · 2026-02-27T00:57:46Z

build2.proj

+          $(TestFilterArgument)
+          $(TestFrameworkArgument)
+          --results-directory "$(TestResultsFolderPath)"
+          --logger:"trx;LogFilePrefix=$(LogFilePrefix)


The unit test dotnet test command has an unterminated --logger: argument (missing the closing quote) and likely a missing closing )/quote at the end of the command block. This will cause the dotnet test invocation to fail when the target runs.

Suggested change

--logger:"trx;LogFilePrefix=$(LogFilePrefix)

--logger:"trx;LogFilePrefix=$(LogFilePrefix)"

Copilot · 2026-02-27T00:57:48Z

build2.proj

+          -SymbolPackageFormat snupkg
+      </NugetCommand>
+      <!-- Convert more than one whitespace character into one space -->
+      <DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>


In PackMds, the whitespace-normalization step is applied to $(DotnetCommand), but the command being built/executed here is $(NugetCommand). As written, $(NugetCommand) will keep the original whitespace/newlines, and $(DotnetCommand) may be unintentionally overwritten. Apply the regex replace to $(NugetCommand) instead.

Suggested change

<DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>

<NugetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(NugetCommand), "\s+", " "))</NugetCommand>

Copilot · 2026-02-27T00:57:48Z

build2.proj

+          $(TestCollectArgument)
+          $(TestFilterArgument)
+          $(TestFrameworkArgument)
+          $(TestPackageReferenceArgument)


$(TestPackageReferenceArgument) is referenced in the functional test command, but this property is never defined (the file defines TestPackageBuildArgument). As a result, ReferenceType=Package / MdsPackageVersion won't be forwarded to the test build. Use the defined property name consistently (or define TestPackageReferenceArgument).

Suggested change

$(TestPackageReferenceArgument)

$(TestPackageBuildArgument)

Copilot · 2026-02-27T00:57:48Z

build2.proj

+      <NugetCommand>
+        nuget pack &quot;$(MdsNuspecPath)&quot;
+          -OutputDirectory &quot;$(MdsArtifactsPath)&quot;
+          -Version &quot;$(MdsPackageVersion)&quot;
+          -Properties &quot;COMMITID=$(CommitHash);Configuration=$(Configuration);&quot;
+          -Symbols
+          -SymbolPackageFormat snupkg
+      </NugetCommand>
+      <!-- Convert more than one whitespace character into one space -->
+      <DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>


PackMds always passes -Version "$(MdsPackageVersion)", but MdsPackageVersion defaults to empty. nuget pack requires a non-empty version (or you should omit -Version to fall back to the nuspec <version>). Consider only adding -Version when $(MdsPackageVersion) is set, or set a sensible default.

Suggested change

<NugetCommand>

nuget pack "$(MdsNuspecPath)"

-OutputDirectory "$(MdsArtifactsPath)"

-Version "$(MdsPackageVersion)"

-Properties "COMMITID=$(CommitHash);Configuration=$(Configuration);"

-Symbols

-SymbolPackageFormat snupkg

</NugetCommand>



<DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>



<VersionArgument Condition=" '$(MdsPackageVersion)' != '' ">-Version "$(MdsPackageVersion)"</VersionArgument>

<NugetCommand>

nuget pack "$(MdsNuspecPath)"

-OutputDirectory "$(MdsArtifactsPath)"

$(VersionArgument)

-Properties "COMMITID=$(CommitHash);Configuration=$(Configuration);"

-Symbols

-SymbolPackageFormat snupkg

</NugetCommand>



<NugetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(NugetCommand), "\s+", " "))</NugetCommand>

Copilot · 2026-02-27T00:57:48Z

build2.proj

+      <GitCommand>
+        git rev-parse HEAD
+      </GitCommand>
+    </PropertyGroup>
+    <Message Text=">>> Fetching git commit hash via command: $(GitCommand)" />
+    <Exec Command="$(GitCommand)" ConsoleToMsBuild="true">
+      <Output TaskParameter="ConsoleOutput" PropertyName="CommitHash" />
+    </Exec>
+
+    <PropertyGroup>
+      <NugetCommand>
+        nuget pack &quot;$(MdsNuspecPath)&quot;
+          -OutputDirectory &quot;$(MdsArtifactsPath)&quot;
+          -Version &quot;$(MdsPackageVersion)&quot;
+          -Properties &quot;COMMITID=$(CommitHash);Configuration=$(Configuration);&quot;
+          -Symbols


CommitHash is captured from git rev-parse HEAD via ConsoleOutput, which typically includes a trailing newline. Passing that directly into -Properties "COMMITID=$(CommitHash)..." can result in an invalid COMMITID value (newline in the property) and potentially break nuget pack property parsing. Trim $(CommitHash) before using it (e.g., strip whitespace/newlines).

Copilot · 2026-02-27T00:57:48Z

tools/specs/Microsoft.Data.SqlClient.nuspec

+    <file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\unix\net9.0\Microsoft.Data.SqlClient.dll" target="runtimes\win\lib\net9.0\" exclude="" />
+    <file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\unix\net9.0\Microsoft.Data.SqlClient.pdb" target="runtimes\win\lib\net9.0\" exclude="" />
+    <file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\windows_nt\net9.0\Microsoft.Data.SqlClient.dll" target="runtimes\unix\lib\net9.0\" exclude="" />
+    <file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\windows_nt\net9.0\Microsoft.Data.SqlClient.pdb" target="runtimes\unix\lib\net9.0\" exclude="" />


The net9.0 runtime entries appear to have the OS targets swapped: files sourced from the Unix build are being placed under runtimes\win\..., and files sourced from the Windows build are being placed under runtimes\unix\.... This will cause the wrong assembly to be selected at runtime for each OS.

Suggested change

<file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\unix\net9.0\Microsoft.Data.SqlClient.dll" target="runtimes\win\lib\net9.0\" exclude="" />

<file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\unix\net9.0\Microsoft.Data.SqlClient.pdb" target="runtimes\win\lib\net9.0\" exclude="" />

<file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\windows_nt\net9.0\Microsoft.Data.SqlClient.dll" target="runtimes\unix\lib\net9.0\" exclude="" />

<file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\windows_nt\net9.0\Microsoft.Data.SqlClient.pdb" target="runtimes\unix\lib\net9.0\" exclude="" />

<file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\unix\net9.0\Microsoft.Data.SqlClient.dll" target="runtimes\unix\lib\net9.0\" exclude="" />

<file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\unix\net9.0\Microsoft.Data.SqlClient.pdb" target="runtimes\unix\lib\net9.0\" exclude="" />

<file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\windows_nt\net9.0\Microsoft.Data.SqlClient.dll" target="runtimes\win\lib\net9.0\" exclude="" />

<file src="..\..\artifacts\Microsoft.Data.SqlClient\$Configuration$\windows_nt\net9.0\Microsoft.Data.SqlClient.pdb" target="runtimes\win\lib\net9.0\" exclude="" />

paulmedynski · 2026-02-27T01:10:03Z

src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj

+
+    <!-- We cannot build netfx unless we are building for Windows. Thus, we will only add netfx if -->
+    <!-- we are building for Windows.                                                              -->
+    <TargetFrameworks Condition="'$(NormalizedTargetOs)' == 'windows_nt'">$(TargetFrameworks);net462</TargetFrameworks>


My workflow to do a sanity check build before I commit is:

dotnet build src

I run this on Linux, and with this change, it will no longer build net462 or any code gated by _WINDOWS, even though that target and code builds just fine on Linux. I guess my new workflow will need to be:

dotnet build src dotnet build src -p:TargetOs=Windows_NT

Will the new build2.proj have a single (default) target that builds everything for all combinations?

It will be nice if/when we can eliminate OS from the matrix and let MSBuild handle the combinations to build everything automatically.

How are IDE developers ensuring that all combinations of Target Framework + TargetOs are compiling before they commit? For example, if I run VSCode in Linux, I won't even see net462 as a target framework. I would have to create some sort of build configs - one for TargetOs Windows_NT and one for Unix I guess?

paulmedynski · 2026-02-27T01:14:20Z

build2.proj

+		  Default value:  Debug
+		  Allowed values: Debug, Release
+		-->
 		<Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>


I'm pretty sure properties specified on the command line are read-only, so if someone says:

dotnet build build2.proj -p:Configuration=Blah

Then nothing in the project files can clobber that. The same goes for properties supplied via the <MSBuild> task AFAIK.

Since this is a top-level file that isn't included anywhere else, do we still need these conditions checking for empty values? It should be safe to just say this, I think?

<Configuration>Debug</Configuration>

paulmedynski · 2026-02-27T12:19:06Z

build2.proj

+      Default value: [blank]
+      Example:       C:\x86\
+    -->
+    <DotnetPath Condition="'$(DotnetPath)' == ''" />


What's the purpose of defining this to be empty if it's already empty? Same for some of the properties below.

paulmedynski · 2026-02-27T12:22:01Z

build2.proj

+      Allowed values: (time_expression|0)
+    -->
+    <TestBlameTimeout Condition="'$(TestBlameTimeout)' == ''">10m</TestBlameTimeout>
+    <TestBlameTimeout Condition="'$(TestBlameTimeout)' == '0'" />


I don't think this has any effect if TestBlameTimeout is set to 0 on the command line.

paulmedynski · 2026-02-27T12:29:11Z

build2.proj

+                      "none" to disable filtering and run all tests in the target.
+                      For more information see:
+                      https://learn.microsoft.com/en-us/dotnet/core/testing/selective-unit-tests
+      Default value:  category!=failing&category!=flaky


Need to add category!=interactive here.

paulmedynski · 2026-02-27T12:32:47Z

build2.proj

+    <!--
+      TestFramework
+      Applies to:    Test* targets
+      Description:   Target framework moniker for the version of the .NET to use to execute the


of the .NET ?

paulmedynski · 2026-02-27T12:33:36Z

build2.proj

+                     specified test target. If not specified, this defaults to running tests for
+                     *all* framework versions supported for the project.
+      Default value: [blank]
+      Example:       net462


Can multiple monikers be speficied at once? net8.0;net9.0

paulmedynski · 2026-02-27T12:34:28Z

build2.proj

+      Description:   Absolute path to directory where any test results should be dumped. If not
+                     specified, this path will default to test_results in the root of the
+                     repository.
+      Default value: $(REPO_ROOT)\test_results


I'm not sure if the existing pipelines set this, and I think they expect the test results in a different directory.

paulmedynski · 2026-02-27T12:36:44Z

build2.proj

+    <MdsNuspecPath>$(RepoRoot)tools/specs/Microsoft.Data.SqlClient.nuspec</MdsNuspecPath>
+
+    <!-- Project Paths -->
+    <MdsFunctionalTestProjectPath>$(MdsRoot)tests/FunctionalTests/Microsoft.Data.SqlClient.FunctionalTests.csproj</MdsFunctionalTestProjectPath>


I'm not sure alphabetical sorting makes the most sense here. I was expecting main project, ref project, test projects. I don't really care though.

paulmedynski · 2026-02-27T12:38:35Z

build2.proj

 			</DotnetCommand>
-			<!-- Convert more than one whitespace character into one space --> 
-			<DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>
+      <!-- Convert more than one whitespace character into one space -->


Weird indentation here, and below.

Copilot AI review requested due to automatic review settings February 25, 2026 19:48

mdaigle requested a review from a team as a code owner February 25, 2026 19:48

Copilot started reviewing on behalf of mdaigle February 25, 2026 19:49 View session

mdaigle changed the title ~~Pack experiment~~ DRAFT Pack experiment Feb 25, 2026

Copilot AI reviewed Feb 25, 2026

View reviewed changes

benrr101 added 6 commits February 26, 2026 11:57

Stubbing out additional targets for build2.proj

9f38b2e

First attempt at a pack target

26e899e

Fix issue with target OS and target frameworks in common MDS build

ae5a1a9

Some in flight changes to build2.proj. Coming back to this in a bit.

e2ca90e

Get common ref project building to artifacts folder, a la common mds …

e6687ff

…project.

Beginning migration of nuspec file

52cf1df

benrr101 force-pushed the dev/russellben/common/pack branch from 8d2321d to 52cf1df Compare February 26, 2026 20:13

benrr101 added 4 commits February 26, 2026 16:19

Add build target to build2.proj for building the ref binaries

c9e4bf5

Remove AKV target from build2.proj as it is not ready for prime time

4b487fa

Getting TestMdsUnit target working

d6f1625

Implement TestMdsFunctional target

cdfb309

Copilot AI review requested due to automatic review settings February 27, 2026 00:51

Copilot started reviewing on behalf of benrr101 February 27, 2026 00:52 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

paulmedynski requested changes Feb 27, 2026

View reviewed changes

benrr101 added 2 commits February 27, 2026 13:07

Adding TestMdsManual target

24a9397

Some AI test nonesense.

ef0dce3

	is required. Othrwise, this defaults to the `nuget` binary in the PATH
	is required. Otherwise, this defaults to the `nuget` binary in the PATH

	<Message Text=">>> Packageing MDS via command: $(NugetCommand)" />
	<Message Text=">>> Packaging MDS via command: $(NugetCommand)" />

		<OutputPath>$(BinFolder)$(Configuration).$(Platform)/$(AssemblyName)/$(_TfmGroup)/</OutputPath>
		<IntermediateOutputPath>$(ObjFolder)$(Configuration).$(Platform)/$(AssemblyName)/$(_TfmGroup)/</IntermediateOutputPath>

		@@ -2,24 +2,56 @@
		<Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

	-OutputDirectory "$(MdsArtifactsPath)"
	-OutputDirectory "$(MdsArtifactsFolder)"

	<DotnetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(DotnetCommand), "\s+", " "))</DotnetCommand>
	<NugetCommand>$([System.Text.RegularExpressions.Regex]::Replace($(NugetCommand), "\s+", " "))</NugetCommand>

		@@ -154,27 +150,29 @@
		<file src="..\..\artifacts\$ReferenceType$\bin\Windows_NT\$Configuration$.AnyCPU\Microsoft.Data.SqlClient\netfx\net462\zh-Hans\Microsoft.Data.SqlClient.resources.dll" target="lib\net462\zh-Hans\" exclude="" />
		<file src="..\..\artifacts\$ReferenceType$\bin\Windows_NT\$Configuration$.AnyCPU\Microsoft.Data.SqlClient\netfx\net462\zh-Hant\Microsoft.Data.SqlClient.resources.dll" target="lib\net462\zh-Hant\" exclude="" />

	--logger:"trx;LogFilePrefix=$(LogFilePrefix)
	--logger:"trx;LogFilePrefix=$(LogFilePrefix)"

Conversation

mdaigle commented Feb 25, 2026

Description

Issues

Testing

Guidelines

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment