Merged
Conversation
- Updated makepfxcert.ps1 to use improved FQCN lookup, and only install OpenSSL module it if isn't installed already. - Improved diatnostigs when running powershell scripts as part of certificate tests.
paulmedynski
added
the
Area\Engineering
paulmedynski
commented
Feb 25, 2026
Contributor
Author
paulmedynski
left a comment
paulmedynski
left a comment
There was a problem hiding this comment.
Commentary for reviewers.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the manual certificate-generation flow used by CertificateTestWithTdsServer on Ubuntu/Linux, aiming to reduce hangs and improve diagnostics when running the PowerShell-based certificate scripts in CI.
Changes:
- Update
makepfxcert.ps1FQDN lookup logic and avoid reinstalling the OpenSSL PowerShell module when already present. - Improve PowerShell script execution diagnostics by capturing and labeling stdout/stderr output in the manual test harness.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient/tests/ManualTests/makepfxcert.ps1 |
Adjusts host/FQDN resolution and makes OpenSSL module installation conditional; adds PowerShell tracing. |
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionTestWithSSLCert/CertificateTestWithTdsServer.cs |
Refactors PowerShell invocation to use pwsh on non-Windows and improves captured output formatting. |
mdaigle
approved these changes
Feb 25, 2026
apoorvdeshmukh
approved these changes
Feb 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3980 +/- ##
==========================================
- Coverage 75.22% 0 -75.23%
==========================================
Files 266 0 -266
Lines 42932 0 -42932
==========================================
- Hits 32294 0 -32294
+ Misses 10638 0 -10638
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Code changes:
These changes will help us diagnose what is hanging the script.
In the meantime, I have also updated our 1ES Ubuntu images to install the powershell OpenSSL module, so the script won't have to.
Testing