Skip to content

fix(binary-field): rollback migration regressions and fix custom element builder styling #33882#34897

Merged
hmoreras merged 4 commits intomainfrom
issue-33882-fix-of-binary-field
Mar 6, 2026
Merged

fix(binary-field): rollback migration regressions and fix custom element builder styling #33882#34897
hmoreras merged 4 commits intomainfrom
issue-33882-fix-of-binary-field

Conversation

@hmoreras
Copy link
Copy Markdown
Member

@hmoreras hmoreras commented Mar 6, 2026

  • Rolls back dot-edit-content-binary-field lib components to their pre-migration state (SCSS-based styles) due to multiple regressions from the Angular 20→21 / PrimeNG 17→21 migration. Restores all deleted SCSS files and HTML templates.

  • Fixes the dotcms-binary-field-builder custom element app by adding Tailwind CSS setup, PrimeNG 21 Lara theme provider (provideDotCMSTheme), dialog backdrop styling, and a button icon alignment override for the global .pi rule conflict.

Screenshare.-.2026-03-06.1_47_29.PM.mp4

This PR fixes: #33882

This PR fixes: #33882

hmoreras added 2 commits March 6, 2026 13:18
…CSS styles, add Tailwind + theme setup, and fix button icon alignment in custom element builder
@hmoreras hmoreras enabled auto-merge March 6, 2026 20:12
@hmoreras hmoreras added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit bf13d19 Mar 6, 2026
23 checks passed
@hmoreras hmoreras deleted the issue-33882-fix-of-binary-field branch March 6, 2026 23:13
spbolton pushed a commit that referenced this pull request Mar 24, 2026
…ent builder styling #33882 (#34897)

- Rolls back dot-edit-content-binary-field lib components to their
pre-migration state (SCSS-based styles) due to multiple regressions from
the Angular 20→21 / PrimeNG 17→21 migration. Restores all deleted SCSS
files and HTML templates.

- Fixes the dotcms-binary-field-builder custom element app by adding
Tailwind CSS setup, PrimeNG 21 Lara theme provider (provideDotCMSTheme),
dialog backdrop styling, and a button icon alignment override for the
global .pi rule conflict.



https://github.com/user-attachments/assets/7cc2b957-601f-4b89-9d56-3ceebf38fd53



This PR fixes: #33882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area : Frontend PR changes Angular/TypeScript frontend code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Modernization: Lara Theme - Upgrade Angular from 20 to 21 & PrimeNG from 17 to 21

3 participants