Skip to content

Jj/mnnamenew#2363

Merged
PsiLupan merged 47 commits intodoldecomp:masterfrom
jurrejelle:jj/mnnamenew
Apr 1, 2026
Merged

Jj/mnnamenew#2363
PsiLupan merged 47 commits intodoldecomp:masterfrom
jurrejelle:jj/mnnamenew

Conversation

@jurrejelle
Copy link
Copy Markdown
Collaborator

@jurrejelle jurrejelle commented Mar 28, 2026

Tracking PR as usual

sysop and others added 23 commits March 28, 2026 08:22
Match InitNameEntryUIState (97%)
088a031 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_8023DA08 (80%)
acac661 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_8023B314 (97%)
fcc94e1 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_8023B224 (100%)
91be6a4 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match fn_8023DAEC (81%)
825af06 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match NameContainsOnlySpaces (97%)
5bcb356 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_8023B0F8 (100%)
a5bef64 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match fn_8023CFC8 (89%)
1709b02 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match AddCharacterToName (85%)
f8ecb8f 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match WriteCharactersForNameAtIndex (90%)
6a85478 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_8023CE4C (86%)
f8ded07 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_8023E0D8 (95%)
8af50c7 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match PickAutoName (92%)
3381756 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_8023BAA8 (100%)
2cd1aa0 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_8023D130 (86%)
6fdfe98 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_GlyphVariantInput (97%)
445ce31 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_8023E32C (90%)
47bfb61 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_EnterFromMnCharSel (91%)
e6eeff2 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match fn_8023DBE8 (95%)
ed363a4
Match mnNameNew_GlyphVariantSetup (92%)
79dcde4
Match mnNameNew_KeySetup (88%)
9a744d0 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Match mnNameNew_MainInput (66%)
8860126 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jurrejelle
Merge branch 'master' into jj/mnnamenew
53d9b3d
@decomp-dev
Copy link
Copy Markdown

decomp-dev Bot commented Mar 28, 2026 •
edited
Loading

Report for GALE01 (0559a4e - 22ddb1b)

📈 Matched code: 61.33% (+0.04%, +1712 bytes)

✅ 5 new matches
Unit Item Bytes Before After
main/melee/mn/mnnamenew mnNameNew_8023BAA8 +676 0.00% 100.00%
main/melee/mn/mnnamenew fn_8023CFC8 +304 0.00% 100.00%
main/melee/mn/mnnamenew mnNameNew_8023B0F8 +300 0.00% 100.00%
main/melee/mn/mnnamenew mnNameNew_8023B314 +232 0.00% 100.00%
main/melee/mn/mnnamenew InitNameEntryUIState +200 0.00% 100.00%
📈 20 improvements in unmatched items
Unit Item Bytes Before After
main/melee/mn/mnnamenew mnNameNew_MainInput +1558 0.00% 67.63%
main/melee/mn/mnnamenew mnNameNew_KeySetup +1468 0.00% 86.00%
main/melee/mn/mnnamenew mnNameNew_GlyphVariantSetup +1439 0.00% 91.79%
main/melee/mn/mnnamenew fn_8023DBE8 +1212 0.00% 95.90%
main/melee/mn/mnnamenew .data +977 0.00% 29.81%
main/melee/mn/mnnamenew mnNameNew_EnterFromMnCharSel +822 0.00% 99.85%
main/melee/mn/mnnamenew mnNameNew_8023E32C +713 0.00% 92.44%
main/melee/mn/mnnamenew mnNameNew_GlyphVariantInput +684 0.00% 97.74%
main/melee/mn/mnnamenew mnNameNew_8023D130 +564 0.00% 81.06%
main/melee/mn/mnnamenew PickAutoName +371 0.00% 91.98%
main/melee/mn/mnnamenew mnNameNew_8023E0D8 +371 0.00% 93.83%
main/melee/mn/mnnamenew mnNameNew_8023CE4C +356 0.00% 93.93%
main/melee/mn/mnnamenew WriteCharactersForNameAtIndex +319 0.00% 89.83%
main/melee/mn/mnnamenew AddCharacterToName +263 0.00% 80.43%
main/melee/mn/mnnamenew NameContainsOnlySpaces +252 0.00% 97.08%
main/melee/mn/mnnamenew fn_8023DAEC +211 0.00% 83.95%
main/melee/mn/mnnamenew mnNameNew_8023DA08 +183 0.00% 80.65%
main/melee/mn/mnnamenew .sdata2 +75 0.00% 94.74%
main/melee/mn/mnnamenew .sdata +70 0.00% 7.77%
main/melee/mn/mnnamenew .rodata +5 0.00% 32.35%

@jurrejelle
add import
e608c73
@jurrejelle
Remove some pointer math
747999b
@jurrejelle
Remove some pointer math
28ab654
@jurrejelle
Remove pointer math in AddCharacterToName and related functions
de6a20b 
Define NameNewData struct to replace raw byte offsets from
mnNameNew_803EDA58 base pointer. Use proper struct member access
(glyph_lower, glyph_upper, glyph_single, glyph_set_a/b/c,
key_counts, ref_pos) instead of casting to u8* and adding magic
offsets like 0x28C, 0x5AC, 0x1C4.

Functions cleaned up:
- AddCharacterToName: data->glyph_lower/upper[(u8)arg1].glyphs
- mnNameNew_KeySetup: ndata->glyph_set_a/b/single (fixes 84.8%->86.2%)
- mnNameNew_8023D130: ndata->ref_pos, GlyphRow table access
- mnNameNew_GlyphVariantSetup: ndata->key_counts, ndata for strings

All match percentages preserved or improved.
@jurrejelle
More pointer math
43526eb
@jurrejelle
More pointer math fixes
2bc1d3b
@jurrejelle jurrejelle marked this pull request as ready for review March 31, 2026 17:33
@PsiLupan PsiLupan merged commit 65ebb34 into doldecomp:master Apr 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jurrejelle @PsiLupan