Add collation tests#225
Open
danielfrankcom wants to merge 9 commits into
Open
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (14234+21 LOC, 62 files); LLM: Adds new collation behavior tests across multiple commands/features, touching test coverage and some framework changes across multiple files. If a label is wrong, remove it manually and ping |
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
eerxuan
requested changes
May 27, 2026
Move capped collection tests from options/ to collection_level/. Move text index tests from options/ to index_level/ and add 2d/2dsphere collation tests covering the restriction boundary (2d rejects non-simple, 2dsphere accepts any collation). Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
Remove dedicated dotted path file (12 tests across multiple commands for the same concern). Add a single dotted path test to test_operations_find.py filter tests instead. Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
eerxuan
approved these changes
May 28, 2026
Signed-off-by: Daniel Frankcom <frankcom@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for collation across commands/features. The intent is to cover semantic behavior of collation in general, so these tests cover a number of different features that could potentially be affected by collation.
While working on this change I found some gaps in the collation testing for the
aggregatecommand, so will add them in #221. The split is the command tests aim to test the syntax and accepted options for the collation configuration, whereas the dedicatedcollationtests focus on the behavior.There is some overlap here with #191 as some of the framework changes are needed by both. I've included them here so they should merge cleanly.