Skip to content

Add $min accumulator tests#219

Open
alinaliBQ wants to merge 16 commits into
documentdb:mainfrom
alinaliBQ:min
Open

Add $min accumulator tests#219
alinaliBQ wants to merge 16 commits into
documentdb:mainfrom
alinaliBQ:min

Conversation

@alinaliBQ
Copy link
Copy Markdown
Contributor

This change adds tests for the $min accumulator operator.

Add accumulator operator tests for $min. Tests database $min behavior, output collection, syntax, and expected errors.
Integration tests are in documentdb_tests/compatibility/tests/core/operator/accumulators/test_accumulators_min_integration.py

@alinaliBQ alinaliBQ marked this pull request as ready for review May 20, 2026 22:34
@alinaliBQ alinaliBQ requested a review from a team as a code owner May 20, 2026 22:34
@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels May 20, 2026
@documentdb-triage-tool
Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort XL · Status Needs Review
Confidence: 0.92 (mixed)

Reasoning

component from path globs (test-coverage, test-framework); effort from diff stats (2919+2 LOC, 12 files); LLM: Adds new integration test coverage for the $min accumulator operator under the compatibility tests path, a meaningful but self-contained test-coverage contribution.

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@alinaliBQ alinaliBQ force-pushed the min branch 2 times, most recently from 647bb79 to 21ba959 Compare May 21, 2026 00:08
@alinaliBQ
Copy link
Copy Markdown
Contributor Author

Removed stage tests and renamed tests to test_accumulator_*.py

Copy link
Copy Markdown
Collaborator

@eerxuan eerxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the same feedback on #214 (review)

@alinaliBQ
Copy link
Copy Markdown
Contributor Author

alinaliBQ commented May 27, 2026

applied #214 (review): add arity tests, expression tests, BSON tests, order dependence tests, and empty-group behavior tests. Remove BSON order tests.

alinaliBQ added 16 commits May 28, 2026 12:01
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
add arity tests, add expression tests, add BSON tests. Remove BSON order tests. Add order dependence tests.

Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants