Skip to content

optional endpoint for metrics aggregator#543

Merged
denis-yuen merged 2 commits intodevelopfrom
feature/optional_endpoint
Apr 14, 2026
Merged

optional endpoint for metrics aggregator#543
denis-yuen merged 2 commits intodevelopfrom
feature/optional_endpoint

Conversation

@denis-yuen
Copy link
Copy Markdown
Member

@denis-yuen denis-yuen commented Apr 10, 2026

Description
Add default for endpoint override to allow it to pass missing properties check

Review Instructions
Can run test manually

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-7290

Security
None

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install in the project that you have modified (until https://ucsc-cgl.atlassian.net/browse/SEAB-5300 adds multi-module support properly)
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If you are changing dependencies, check with dependabot to ensure you are not introducing new high/critical vulnerabilities
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Apr 10, 2026
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.83%. Comparing base (447a154) to head (1e598fb).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #543   +/-   ##
==========================================
  Coverage      15.83%   15.83%           
  Complexity       100      100           
==========================================
  Files             40       40           
  Lines           2337     2337           
  Branches         186      186           
==========================================
  Hits             370      370           
  Misses          1943     1943           
  Partials          24       24           
Flag Coverage Δ
metricsaggregator 10.48% <100.00%> (ø)
toolbackup 15.83% <100.00%> (ø)
tooltester 10.48% <100.00%> (ø)
topicgenerator 10.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@denis-yuen denis-yuen marked this pull request as ready for review April 10, 2026 20:33
@denis-yuen denis-yuen requested review from a team, nolunwa-ucsc and svonworl and removed request for a team April 10, 2026 20:33
@denis-yuen denis-yuen changed the title Feature/optional endpoint optional endpoint for metrics aggregator Apr 10, 2026
@denis-yuen denis-yuen merged commit e6c64a3 into develop Apr 14, 2026
14 checks passed
@denis-yuen denis-yuen deleted the feature/optional_endpoint branch April 14, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants