Skip to content

fix: reduce retained tool output memory#2854

Open
dgageot wants to merge 4 commits into
docker:mainfrom
dgageot:board/e34279a60727904e
Open

fix: reduce retained tool output memory#2854
dgageot wants to merge 4 commits into
docker:mainfrom
dgageot:board/e34279a60727904e

Conversation

@dgageot
Copy link
Copy Markdown
Member

@dgageot dgageot commented May 21, 2026 •
edited
Loading

  • wait for lifecycle supervisor watcher goroutines during shutdown
  • bound retained tool output in session history with a regression test
  • spool large MCP media payloads to disk instead of retaining inline base64
  • slim retained TUI tool results and avoid duplicating file contents in metadata

@dgageot dgageot requested a review from a team as a code owner May 21, 2026 12:13
rumpl
rumpl reviewed May 21, 2026
View reviewed changes
Comment thread pkg/runtime/toolexec/dispatcher.go
c.addMessage(&msg)
}

// buildMultiContent attaches inline images to a tool response as a

This comment was marked as outdated.

Sign in to view

rumpl
rumpl reviewed May 21, 2026
View reviewed changes
Comment thread pkg/runtime/toolexec/dispatcher.go Outdated
// buildMultiContent attaches inline images to a tool response as a
// MultiContent payload, following the data-URL convention expected by
// chat clients.
func retainedToolOutput(output string, maxOldToolCallTokens int) string {

This comment was marked as outdated.

Sign in to view

@dgageot dgageot marked this pull request as draft May 21, 2026 12:23
@docker-agent

This comment was marked as low quality.

Sign in to view
@dgageot dgageot force-pushed the board/e34279a60727904e branch from 2104c15 to bb2f838 Compare May 21, 2026 13:44
@dgageot dgageot marked this pull request as ready for review May 21, 2026 13:56
@docker-agent
Copy link
Copy Markdown

docker-agent commented May 21, 2026

❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs.

@aheritier aheritier added area/agent For work that has to do with the general agent loop/agentic features of the app kind/fix PR fixes a bug (maps to fix: commit prefix) labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rumpl rumpl rumpl left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/agent For work that has to do with the general agent loop/agentic features of the app kind/fix PR fixes a bug (maps to fix: commit prefix)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgageot @docker-agent @rumpl @aheritier