Skip to content

Fix 2089 - emoji rendering in iTerm2#2099

Merged
dgageot merged 1 commit intodocker:mainfrom
dgageot:fix-2089
Mar 13, 2026
Merged

Fix 2089 - emoji rendering in iTerm2#2099
dgageot merged 1 commit intodocker:mainfrom
dgageot:fix-2089

Conversation

@dgageot
Copy link
Member

@dgageot dgageot commented Mar 13, 2026

No description provided.

Signed-off-by: David Gageot <david.gageot@docker.com>
@dgageot dgageot requested a review from a team as a code owner March 13, 2026 15:55
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Assessment: 🟢 APPROVE

Summary

This PR adds a replace directive to use a personal fork of github.com/charmbracelet/ultraviolet to fix issue #2089 related to emoji rendering in iTerm2.

Analysis:

  • The replace directive syntax is correct and follows Go module conventions
  • The go.sum entries are properly updated (old upstream entries removed, new fork entries added)
  • Using a personal fork via replace is a standard Go development pattern for testing fixes before they're merged upstream
  • The future timestamp (2026) in the pseudo-version, while unusual, is valid - it reflects the Git commit timestamp and doesn't indicate a bug or security issue
  • The PR author (dgageot) is the same as the fork owner, making this a transparent, reviewable change

Findings: No bugs detected in the changed code.

The dependency management changes are implemented correctly according to Go module best practices.


Automated review by docker-agent PR reviewer

@dgageot dgageot merged commit f5d618e into docker:main Mar 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants