Fix 2089 - emoji rendering in iTerm2#2099
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 13, 2026
Merged
Conversation
Signed-off-by: David Gageot <david.gageot@docker.com>
rumpl
approved these changes
Mar 13, 2026
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
Summary
This PR adds a replace directive to use a personal fork of github.com/charmbracelet/ultraviolet to fix issue #2089 related to emoji rendering in iTerm2.
Analysis:
- The replace directive syntax is correct and follows Go module conventions
- The go.sum entries are properly updated (old upstream entries removed, new fork entries added)
- Using a personal fork via
replaceis a standard Go development pattern for testing fixes before they're merged upstream - The future timestamp (2026) in the pseudo-version, while unusual, is valid - it reflects the Git commit timestamp and doesn't indicate a bug or security issue
- The PR author (dgageot) is the same as the fork owner, making this a transparent, reviewable change
Findings: No bugs detected in the changed code.
The dependency management changes are implemented correctly according to Go module best practices.
Automated review by docker-agent PR reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.