fix: hyphens are not valid in identifiers in template expressions#87
Open
forivall wants to merge 2 commits intodlvandenberg:mainfrom
Open
fix: hyphens are not valid in identifiers in template expressions#87forivall wants to merge 2 commits intodlvandenberg:mainfrom
forivall wants to merge 2 commits intodlvandenberg:mainfrom
Conversation
Owner
|
Hi @forivall ! Thanks for the contribution :) Can you update the version in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change also is the beginning of a separation between the parsing of the binding attributes (as defined in the angular compiler's
binding_parser.ts) from the expression parser, as identifiers in expressions are much stricter than what is allowed in parsing html attribute names (which are then parsed by the binding parser, as seen above)