Skip to content

Add change log entry for ^^ operator handling changes#22838

Merged
thewilsonator merged 1 commit intodlang:masterfrom
xoxorwr:patch-2
Mar 30, 2026
Merged

Add change log entry for ^^ operator handling changes#22838
thewilsonator merged 1 commit intodlang:masterfrom
xoxorwr:patch-2

Conversation

@xoxorwr
Copy link
Copy Markdown
Contributor

@xoxorwr xoxorwr commented Mar 30, 2026

People keep forgetting to including a change log entry, this is annoying to track.

There should be a CI gate to block any PR modifying druntime that does not include a corresponding changelog entry.

#22831

#22835

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @xoxorwr! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22838"

@thewilsonator thewilsonator merged commit 371c7a5 into dlang:master Mar 30, 2026
42 checks passed
@xoxorwr xoxorwr deleted the patch-2 branch March 30, 2026 13:15
@@ -0,0 +1,9 @@
Translate ^^ operator to druntime hook

The exponentiation operator (^^) is now lowered to a druntime hook call instead of being expanded inline by the compiler.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was never expanded inline by the compiler. Previously it was forwarding to std.math in phobos.

Copy link
Copy Markdown
Contributor Author

@xoxorwr xoxorwr Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another reason to enforce change log entries to be written with the PR by its author, I remembered wrong, I should have checked the diff properly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to add one, but I'm still working on this but was away on Sunday so I didn't respond immediately. Thanks for adding one in the mean time though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants