Add change log entry for ^^ operator handling changes#22838
Add change log entry for ^^ operator handling changes#22838thewilsonator merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @xoxorwr! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22838" |
| @@ -0,0 +1,9 @@ | |||
| Translate ^^ operator to druntime hook | |||
|
|
|||
| The exponentiation operator (^^) is now lowered to a druntime hook call instead of being expanded inline by the compiler. | |||
There was a problem hiding this comment.
It was never expanded inline by the compiler. Previously it was forwarding to std.math in phobos.
There was a problem hiding this comment.
Another reason to enforce change log entries to be written with the PR by its author, I remembered wrong, I should have checked the diff properly.
There was a problem hiding this comment.
I was going to add one, but I'm still working on this but was away on Sunday so I didn't respond immediately. Thanks for adding one in the mean time though!
People keep forgetting to including a change log entry, this is annoying to track.
There should be a CI gate to block any PR modifying druntime that does not include a corresponding changelog entry.
#22831
#22835