Skip to content

Detect assignment to struct rvalue with only const pointers & add changelog#22834

Merged
thewilsonator merged 2 commits intodlang:masterfrom
ntrel:struct-rvalue-const
Mar 29, 2026
Merged

Detect assignment to struct rvalue with only const pointers & add changelog#22834
thewilsonator merged 2 commits intodlang:masterfrom
ntrel:struct-rvalue-const

Conversation

@ntrel
Copy link
Copy Markdown
Contributor

@ntrel ntrel commented Mar 28, 2026

Follow up to #22369.
A tail-const pointer field should not prevent detection of discarded assignment.

Move misplaced legacy docs to changelog, as the error applies regardless of edition.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22834"

@thewilsonator thewilsonator merged commit ca244ef into dlang:master Mar 29, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants