Add support for ImportC by turning them to .di on the fly#798
Open
bangbangsheshotmedown wants to merge 6 commits intodlang-community:masterfrom
Open
Add support for ImportC by turning them to .di on the fly#798bangbangsheshotmedown wants to merge 6 commits intodlang-community:masterfrom
bangbangsheshotmedown wants to merge 6 commits intodlang-community:masterfrom
Conversation
|
Thanks for your Pull Request and making D better! This comment will automatically be updated to summarize some statistics in a few minutes. |
Author
Author
|
I forgot to say, this needs a patch for DMD, because -Hf never prints to output, i'll send a PR |
Author
|
I forgot, they banned me from the repo, @WebFreak001 can you submit the patch for me please? PR: Generate .di to stdout if name is "-" This matches the behavior of $ git diff compiler/src/dmd/main.d
diff --git a/compiler/src/dmd/main.d b/compiler/src/dmd/main.d
index 9a04c16b9f..4458e623b5 100644
--- a/compiler/src/dmd/main.d
+++ b/compiler/src/dmd/main.d
@@ -582,7 +582,12 @@ private int tryMain(const(char)[][] argv, out Param params)
buf.reset(); // reuse the buffer
genhdrfile(m, params.dihdr.fullOutput, buf);
- if (!writeFile(m.loc, m.hdrfile.toString(), buf[]))
+
+ if (params.dihdr.name == "-") {
+ size_t n = fwrite(buf[].ptr, 1, buf.length, stdout);
+ assert(n == buf.length);
+ }
+ else if (!writeFile(m.loc, m.hdrfile.toString(), buf[]))
fatal();
}
} |
Author
Author
|
A PR for it got merged: dlang/dmd#22662 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Works like a charm:
There is also -X, wich generates a json, i wonder if that can be used for templates/mixins, i'll experiment for an other PR