Skip to content

refactor(cli): extract magic numbers to named constants#6

Merged
lostmygithubaccount merged 1 commit into
mainfrom
cody/extract-constants
Apr 5, 2026
Merged

refactor(cli): extract magic numbers to named constants#6
lostmygithubaccount merged 1 commit into
mainfrom
cody/extract-constants

Conversation

@lostmygithubaccount
Copy link
Copy Markdown
Member

Summary

  • Extract 4096 and 50 magic numbers in CLI arg defaults to DEFAULT_CTX_SIZE and DEFAULT_LOG_LINES named constants

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@lostmygithubaccount lostmygithubaccount enabled auto-merge (squash) April 5, 2026 22:18
@lostmygithubaccount lostmygithubaccount merged commit eb0c163 into main Apr 5, 2026
1 check passed
@lostmygithubaccount lostmygithubaccount deleted the cody/extract-constants branch April 5, 2026 22:20
lostmygithubaccount added a commit that referenced this pull request Apr 13, 2026
Patch release rolling up four unreleased commits since v0.2.0:
- feat(py): add `attach` binding and fix README Rust example (#4)
- test(core): expand test coverage (#5)
- refactor(cli): extract magic numbers to named constants (#6)
- chore: update dependencies (#7)

Bumped via `bin/bump-version --patch`, which updates:
- pyproject.toml
- crates/dkdc-lm-core/Cargo.toml
- crates/dkdc-lm-cli/Cargo.toml
- crates/dkdc-lm-py/Cargo.toml
- inter-crate dep versions in dkdc-lm-cli
- Cargo.lock, crates/dkdc-lm-py/Cargo.lock, uv.lock

Also introduces CHANGELOG.md (Keep a Changelog) since the repo did not
have one; populated with this release entry only.
@lostmygithubaccount lostmygithubaccount mentioned this pull request Apr 13, 2026
3 tasks
lostmygithubaccount added a commit that referenced this pull request Apr 13, 2026
Patch release rolling up four unreleased commits since v0.2.0:
- feat(py): add `attach` binding and fix README Rust example (#4)
- test(core): expand test coverage (#5)
- refactor(cli): extract magic numbers to named constants (#6)
- chore: update dependencies (#7)

Bumped via `bin/bump-version --patch`, which updates:
- pyproject.toml
- crates/dkdc-lm-core/Cargo.toml
- crates/dkdc-lm-cli/Cargo.toml
- crates/dkdc-lm-py/Cargo.toml
- inter-crate dep versions in dkdc-lm-cli
- Cargo.lock, crates/dkdc-lm-py/Cargo.lock, uv.lock

Also introduces CHANGELOG.md (Keep a Changelog) since the repo did not
have one; populated with this release entry only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant