fix(zorto/install): POSIX-correct redirect + post-install PATH nudge#16
Merged
Merged
Conversation
✅ Deploy Preview for dkdcsh ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The shebang declares /usr/bin/env sh but line 7 used the bash-only `&>/dev/null` redirect, which fails under dash, ash, and busybox sh. Anyone curl|sh'ing on Debian/Ubuntu (where /bin/sh is dash), Alpine, or a minimal container would hit "syntax error near unexpected token" before uv even gets a chance to run. Switch to the POSIX `>/dev/null 2>&1` form. Verified with `dash -n` and `sh -n`. Also append a post-install line that calls `zorto --version` and, on failure, hints that ~/.local/bin (where uv tool installs land) may not be on $PATH. This is the most common first-impression footgun for fresh shells. No version bump; this script is served raw from static/.
lostmygithubaccount
force-pushed
the
fix/zorto-install-sh-posix
branch
from
f6356fb to
4a12c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&>/dev/nullfor POSIX>/dev/null 2>&1instatic/zorto/install.sh. The shebang declares#!/usr/bin/env shso&>(a bash-4 merge-redirect) breaks under dash, ash, and busybox sh. Anyone curl|sh'ing on Debian/Ubuntu (where/bin/shis dash), Alpine, or a minimal container hitssyntax error near unexpected tokenbefore uv even gets a chance to install.zorto --version || echo "...add ~/.local/bin to your PATH...". uv tool installs land in~/.local/bin, which is not on$PATHfor fresh macOS zsh sessions (no.zprofileentry) or many Linux distros. Most common first-impression footgun.Test plan
dash -n static/zorto/install.shpassessh -n static/zorto/install.shpassesshellcheck static/zorto/install.sh(not available locally; recommend running in CI if dkdc.sh adopts shellcheck)curl -LsSf https://dkdc.sh/zorto/install.sh | dashafter deploySurfaced as a BLOCKER in agent8's zorto packaging audit (2026-04-13).