Skip to content

fix(ui): replace header parse().unwrap() with from_static() #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lostmygithubaccount merged 2 commits into from
Apr 6, 2026
Merged

fix(ui): replace header parse().unwrap() with from_static() #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6589baf
fix(ui): use HeaderValue::from_static instead of parse().unwrap()
lostmygithubaccount Apr 6, 2026
01babd9
fix: use axum::http::HeaderValue and document catalog unwrap invariants
lostmygithubaccount Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/dkdc-db-core/src/catalog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,8 @@ fn extract_name_token(s: &str) -> Option<String> {
if ch == '"' || ch == '`' || ch == '\'' {
// Quoted segment: read until matching close quote
let quote = ch;
result.push(chars.next().unwrap());
chars.next(); // consume the opening quote (peeked above)
result.push(quote);
loop {
let c = chars.next()?; // unclosed quote → None
result.push(c);
Expand All @@ -241,7 +242,8 @@ fn extract_name_token(s: &str) -> Option<String> {
// End of name token
break;
} else {
result.push(chars.next().unwrap());
// Safe: peek() confirmed a char exists above
result.push(chars.next().expect("peeked char"));
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/dkdc-db-server/src/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ async fn api_drop_db(State(mgr): State<AppState>, Path(name): Path<String>) -> R
let mut response = Html(String::new()).into_response();
response
.headers_mut()
.insert("HX-Redirect", "/ui".parse().unwrap());
.insert("HX-Redirect", axum::http::HeaderValue::from_static("/ui"));
response
}
Err(e) => Html(format!(
Expand Down
Loading