fix(catalog): harden DDL table name extraction#30
Merged
Conversation
…lified names The function now works on original-case SQL (not uppercased), handles quoted identifiers containing spaces, and extracts the table segment from schema-qualified names (schema.table → table). Adds 17 unit tests covering edge cases. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extract_ddl_table_nameto work on original-case SQL instead of uppercased input, doing case-insensitive keyword matching while preserving the table name's original case"my table") by parsing quote-delimited segments instead of naive whitespace splittingmyschema.mytable→ extractsmytable)Fallback to full refresh remains unchanged — correctness here is an optimization.
🤖 Generated with Claude Code