fix(catalog): consistent case handling and lock release during DDL refresh#26
Merged
Merged
Conversation
…fresh Lowercase table names from sqlite_master in list_tables() to match extract_ddl_table_name() which already lowercases. Drop the read lock on dbs before calling refresh_for_ddl() so concurrent queries aren't blocked during catalog updates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema::list_tables()(reads from sqlite_master) to matchextract_ddl_table_name()which already lowercases, fixing case mismatch between full refresh and incremental DDL refresh pathsdbsread lock before callingrefresh_for_ddl()inDbManager::execute()so concurrent queries aren't blocked during catalog updates🤖 Generated with Claude Code