Skip to content

Code quality fix - String literals should not be duplicated. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisal-hameed wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Code quality fix - String literals should not be duplicated. #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions app/src/main/java/de/sopa/manager/ResourcesManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import org.andengine.opengl.texture.region.TextureRegion;
import org.andengine.opengl.vbo.VertexBufferObjectManager;

import java.lang.String;
import java.util.Map;

import static android.graphics.Color.TRANSPARENT;
Expand All @@ -30,6 +31,7 @@
public class ResourcesManager {

private static final ResourcesManager INSTANCE = new ResourcesManager();
public static final String IMPACT_TTF = "Impact.ttf";
public StoryService storyService;

public Engine engine;
Expand Down Expand Up @@ -110,16 +112,16 @@ public void loadLoadingSceneResources() {
public void loadGameSceneResources() {

loadGameSceneGraphics();
scoreFont = resourceLoader.getFont("Impact.ttf", 200, WHITE, 2, TRANSPARENT);
minMovesFont = resourceLoader.getFont("Impact.ttf", 200, WHITE, 2, TRANSPARENT);
levelFont = resourceLoader.getFont("Impact.ttf", 200, WHITE, 2, TRANSPARENT);
scoreFont = resourceLoader.getFont(IMPACT_TTF, 200, WHITE, 2, TRANSPARENT);
minMovesFont = resourceLoader.getFont(IMPACT_TTF, 200, WHITE, 2, TRANSPARENT);
levelFont = resourceLoader.getFont(IMPACT_TTF, 200, WHITE, 2, TRANSPARENT);
}


public void loadJustPlayScoreResources() {

levelCompleteFont = resourceLoader.getFont("Impact.ttf", 200, WHITE, 0, TRANSPARENT);
justPlayScoreFont = resourceLoader.getFont("Impact.ttf", 125, WHITE, 0, TRANSPARENT);
levelCompleteFont = resourceLoader.getFont(IMPACT_TTF, 200, WHITE, 0, TRANSPARENT);
justPlayScoreFont = resourceLoader.getFont(IMPACT_TTF, 125, WHITE, 0, TRANSPARENT);
nextJustPlayLevel.getTexture().load();
backToMenuRegionP.getTexture().load();
shareScoreTexture.getTexture().load();
Expand All @@ -137,8 +139,8 @@ public void loadLevelChoiceSceneResources() {
levelChoiseStarRegion.getTexture().load();
levelChoiseStarSWRegion.getTexture().load();

levelChoiceFont = resourceLoader.getFont("Impact.ttf", 110, 0xFFca540f, 0, 0xFFca540f);
levelChoiceSWFont = resourceLoader.getFont("Impact.ttf", 110, 0xFF808080, 0, 0xFF808080);
levelChoiceFont = resourceLoader.getFont(IMPACT_TTF, 110, 0xFFca540f, 0, 0xFFca540f);
levelChoiceSWFont = resourceLoader.getFont(IMPACT_TTF, 110, 0xFF808080, 0, 0xFF808080);
}


Expand All @@ -164,7 +166,7 @@ private void loadMenuSceneGraphics() {
creditsRegion.getTexture().load();
twitterLogoRegion.getTexture().load();
shareLogoTexture.getTexture().load();
sopaFont = resourceLoader.getFont("Impact.ttf", 290, 0xFFD6D6D6, 0, TRANSPARENT);
sopaFont = resourceLoader.getFont(IMPACT_TTF, 290, 0xFFD6D6D6, 0, TRANSPARENT);
}


Expand Down Expand Up @@ -294,9 +296,9 @@ public void unloadSettingsScene() {

public void loadLevelCreditsSceneResources() {

creditsHeading = resourceLoader.getFont("Impact.ttf", 200, WHITE, 2, TRANSPARENT);
creditsSubHeading = resourceLoader.getFont("Impact.ttf", 100, WHITE, 2, TRANSPARENT);
creditsText = resourceLoader.getFont("Impact.ttf", 50, WHITE, 2, TRANSPARENT);
creditsHeading = resourceLoader.getFont(IMPACT_TTF, 200, WHITE, 2, TRANSPARENT);
creditsSubHeading = resourceLoader.getFont(IMPACT_TTF, 100, WHITE, 2, TRANSPARENT);
creditsText = resourceLoader.getFont(IMPACT_TTF, 50, WHITE, 2, TRANSPARENT);
}


Expand Down Expand Up @@ -387,7 +389,7 @@ public void unloadJustPlayScoreResources() {

public void loadLevelModeCompleteResources() {
levelModeCup.getTexture().load();
levelModeCompleteFont = resourceLoader.getFont("Impact.ttf", 200, WHITE,0, TRANSPARENT);
levelModeCompleteFont = resourceLoader.getFont(IMPACT_TTF, 200, WHITE,0, TRANSPARENT);
}

public void unLoadLevelModeCompleteResources() {
Expand Down